fix typos in keycard comments, the inverted p2pk hash and mnemonic type wording, and jade decoding error messages
What the developer wrote
Authored by Craig Raw
fix typos in keycard comments, the inverted p2pk hash and mnemonic type wording, and jade decoding error messages
What changed, and why it matters
This commit only fixes spelling mistakes in code comments and user-facing error messages. It changes no program logic, no security checks, and no cryptographic behavior. There is no security issue here.
No security action required. Treat as a routine documentation/typo cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates two git submodules (drongo, lark) and corrects four typos in Java source comments/Javadoc: ‘formats the the card understands’ → ‘formats the card understands’, ‘raw card reponse’ → ‘raw card response’ (twice), and a Jade decoding error message string. No executable code, control flow, or cryptographic operations are modified.
Changed components
src/main/java/com/sparrowwallet/sparrow/io/keycard/BIP32KeyPair.javasrc/main/java/com/sparrowwallet/sparrow/io/keycard/KeycardCommandSet.javadrongo submodulelark submoduleInspect captured patch +5 / −5
### drongo
@@ -1 +1 @@
-Subproject commit 3a60bd6453f5428fc81ad3822c35bfae04c581cc
+Subproject commit 1804f3487e57d1daab00474869fa173db7265f1e
### lark
@@ -1 +1 @@
-Subproject commit 824738d3920aa4080d9ddaa35a96c6a53fee52f0
+Subproject commit 07a467fd283caae30da3f86ee61044f48b6dc04d
### src/main/java/com/sparrowwallet/sparrow/io/keycard/BIP32KeyPair.java
@@ -4,7 +4,7 @@
/**
* Represents a BIP32 keypair. This can be a master key or any other key in the path. Contains convenience method to
- * read and write formats the the card understands.
+ * read and write formats the card understands.
*/
public class BIP32KeyPair {
private byte[] privateKey;
### src/main/java/com/sparrowwallet/sparrow/io/keycard/KeycardCommandSet.java
@@ -611,7 +611,7 @@ private byte poToP2(boolean publicOnly) {
* Sends an EXPORT KEY APDU to export the current key.
*
* @param publicOnly exports only the public key
- * @return the raw card reponse
+ * @return the raw card response
* @throws IOException communication error
*/
public APDUResponse exportCurrentKey(boolean publicOnly) throws IOException {
@@ -622,7 +622,7 @@ public APDUResponse exportCurrentKey(boolean publicOnly) throws IOException {
* Sends an EXPORT KEY APDU to export the current key.
*
* @param p2 the p2 parameter
- * @return the raw card reponse
+ * @return the raw card response
* @throws IOException communication error
*/
public APDUResponse exportCurrentKey(byte p2) throws IOException {Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.