stop the external proxy status check while offline, and restart it on going online
What changed, and why it matters
This commit fixes a minor behavior issue in the Sparrow Wallet desktop app. When the user's internet connection was offline, the app would keep trying to check the status of an external Tor/proxy connection and could show confusing or incorrect status icons. The change simply pauses the proxy status check while offline and refreshes the Tor icon when the app comes back online. There is no direct evidence this is a security vulnerability, and no exploit path is described.
Treat as a routine bug fix or hardening change. No urgent security action is warranted based on the commit alone. If reviewing for a security advisory, request additional context from the project maintainers.
Security signals we found
Behavioral hardening: avoids external proxy status probes while offline
UI state consistency fix for Tor/proxy indicator
No explicit security claim in commit message or diff
Evidence from the diff
The patch modifies AppController.java to call setTorIcon() when the server’s online status changes, and updates TorStatusLabel.update() to cancel the external proxy/Tor connection test when the app is offline (AppServices.onlineProperty() is false). Previously, the status check ran regardless of online state. This is a hardening/UX fix to avoid unnecessary network checks and stale UI state, not a clear security bug fix.
Changed components
Sparrow Wallet desktop appAppController.javaTorStatusLabel.javaExternal proxy/Tor status indicatorInspect captured patch +5 / −2
### src/main/java/com/sparrowwallet/sparrow/AppController.java
@@ -255,7 +255,10 @@ public class AppController implements Initializable {
private final Map<File, File> renamedWallets = new HashMap<>();
private final ChangeListener<Boolean> serverToggleOnlineListener = (observable, oldValue, newValue) -> {
- Platform.runLater(() -> setServerToggleTooltip(getCurrentBlockHeight()));
+ Platform.runLater(() -> {
+ setServerToggleTooltip(getCurrentBlockHeight());
+ setTorIcon();
+ });
};
private final ListChangeListener<Tab> tabsChangeListener = (c) -> {
### src/main/java/com/sparrowwallet/sparrow/control/TorStatusLabel.java
@@ -34,7 +34,7 @@ public TorStatusLabel() {
}
public void update() {
- if(!Config.get().isUseProxy()) {
+ if(!Config.get().isUseProxy() || !AppServices.onlineProperty().get()) {
torConnectionTest.cancel();
if(AppServices.isTorRunning()) {
setTooltip(new Tooltip("Internal Tor proxy enabled"));Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.