AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 33 Bitcoin

keep an entered https or ssl when the host entered is also the alias of a saved server at another protocol

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
keep an entered https or ssl when the host entered is also the alias of a saved server at another protocol
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a UI/server-selection bug in Sparrow Wallet's settings screen. Previously, if a user typed a server host that was also a saved nickname ('alias') for a different server using a different protocol (for example, HTTP vs HTTPS), the wallet could silently switch back to the saved alias's protocol and server details instead of keeping what the user actually entered. The change makes the wallet only treat the saved alias as active when the port and protocol the user entered exactly match that saved alias. In practical terms, it prevents the wallet from accidentally connecting to the wrong server when a host name overlaps with a saved alias.

Recommended action

Treat as a low-to-moderate correctness fix with possible security implications. Review whether the alias-matching logic is used anywhere else in the codebase and ensure similar protocol/port validation is applied consistently. No immediate emergency response is indicated, but users relying on aliases should verify server connections after upgrading. Consider adding a regression test for the alias/protocol overlap scenario.

Security signals we found

01

Incorrect server selection could cause wallet to connect to attacker-controlled or unintended Electrum/Bitcoin Core server

02

Alias resolution did not previously require matching protocol and port, allowing saved server to override user-entered values

03

UI state/config sync inconsistency: SSL toggle path skipped config update when alias was detected

04

Fix adds explicit protocol+port validation before treating a host string as a saved alias

Risk score

Why this scored 33/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.