AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 58 Bitcoin

apply the required all sighash to the inputs of a psbt with silent payment outputs in the transaction tab, and check each input a card will sign before it signs any

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
apply the required all sighash to the inputs of a psbt with silent payment outputs in the transaction tab, and check each input a card will sign before it signs any
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes how Sparrow Wallet handles Bitcoin transactions that use silent payments. Silent payments require every input to be signed with SIGHASH_ALL, meaning the signature covers the whole transaction. Previously, the wallet might have let a hardware card sign an input with a weaker signature type, or let the user pick a different one in the transaction tab. The patch forces SIGHASH_ALL on all inputs when silent payment outputs are present, and makes each card check that requirement before signing anything. A wrong sighash could let an attacker alter parts of the transaction after some inputs are signed, potentially redirecting funds or breaking the silent-payment protocol.

Recommended action

Users who create or sign silent payment transactions should upgrade to the release containing this commit. Developers should review the drongo subproject bump for related sighash/silent-payment changes and verify that verifySilentPaymentSigHash throws a clear exception when an incompatible sighash is present.

Security signals we found

01

silent payment sighash enforcement

02

SIGHASH_ALL coercion for silent payment outputs

03

pre-sign sighash verification in hardware card APIs

04

transaction tab sighash UI restriction

Risk score

Why this scored 58/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.