direct the user to the log when a paynym notification transaction fails to broadcast
What changed, and why it matters
This commit changes the error message shown to users when a PayNym notification transaction fails to broadcast. Instead of displaying the raw technical error message from the server directly in the popup, Sparrow now shows a user-friendly message directing them to the log file for the server response. This is a usability improvement, not a security fix.
No security action required. Treat as a routine UX/logging change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch replaces two calls to AppServices.showErrorDialog() that previously passed failedEvent.getSource().getException().getMessage() as the dialog body. The new message is a static, sanitized string telling the user to check the log file. The exception is still logged at error level. There is no code change affecting transaction handling, network logic, cryptography, or error handling flow.
Changed components
PayNymController.javaSendController.javaInspect captured patch +2 / −2
### src/main/java/com/sparrowwallet/sparrow/paynym/PayNymController.java
@@ -601,7 +601,7 @@ private void broadcastNotificationTransaction(Wallet decryptedWallet, WalletTran
log.error("Error broadcasting notification transaction", failedEvent.getSource().getException());
retrievePayNymProgress.setVisible(false);
followingList.refresh();
- AppServices.showErrorDialog("Error broadcasting notification transaction", failedEvent.getSource().getException().getMessage());
+ AppServices.showErrorDialog("Error broadcasting notification transaction", "The server returned an error when broadcasting the notification transaction. The server response is contained in the log (See Help > Show Log File).");
});
retrievePayNymProgress.setVisible(true);
notificationTransactions.put(transaction.getTxId(), payNym);
### src/main/java/com/sparrowwallet/sparrow/wallet/SendController.java
@@ -1328,7 +1328,7 @@ public void broadcastNotification(Wallet decryptedWallet) {
broadcastTransactionService.setOnFailed(failedEvent -> {
proxyWorker.end();
log.error("Error broadcasting notification transaction", failedEvent.getSource().getException());
- AppServices.showErrorDialog("Error broadcasting notification transaction", failedEvent.getSource().getException().getMessage());
+ AppServices.showErrorDialog("Error broadcasting notification transaction", "The server returned an error when broadcasting the notification transaction. The server response is contained in the log (See Help > Show Log File).");
});
ServiceProgressDialog progressDialog = new ServiceProgressDialog("Broadcast", "Broadcast Notification Transaction", new DialogImage(DialogImage.Type.PAYNYM), proxyWorker);
progressDialog.initOwner(notificationButton.getScene().getWindow());Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.