use language-independent sid for windows users group permission
What the developer wrote
Authored by doblon8
use language-independent sid for windows users group permission
What changed, and why it matters
This commit fixes a Windows build script bug. Previously, the build process granted file permissions to a group literally named 'Users', which fails on non-English Windows versions where that group has a translated name. The change uses the universal numeric identifier (SID) for the Users group instead, so the build works on all language versions of Windows. It is a reliability/localization fix, not a security vulnerability fix.
No security action required. Treat as a normal build/maintenance fix. Reviewers may optionally confirm the SID S-1-5-32-545 is correct for the intended well-known Users group.
Security signals we found
No security-relevant signal: change is a localization/hardcoding fix
Permission grant remains unchanged: still grants Users group full control on build directory
No change to attack surface, privilege boundary, or trust model
Evidence from the diff
In build.gradle, the addUserWritePermission task for Windows now uses the well-known SID S-1-5-32-545 (the ‘Users’ group) instead of the localized string ‘Users’ when invoking icacls. This prevents build failures on non-English Windows systems where the group name is localized. The change does not alter the permission level (still full control, inherited), the target directory, or the set of users receiving the permission; it only makes the group reference language-independent.
Changed components
build.gradle addUserWritePermission task (Windows build path only)Inspect captured patch +2 / −1
diff --git a/build.gradle b/build.gradle
index 63038eb..77cbf16 100644
--- a/build.gradle
+++ b/build.gradle
@@ -285,7 +285,8 @@ if(os.linux) {
tasks.register('addUserWritePermission', Exec) {
if(os.windows) {
- commandLine 'icacls', "$buildDir\\image\\legal", '/grant', 'Users:(OI)(CI)F', '/T'
+ def usersGroup = '*S-1-5-32-545' // Windows "Users" group SID (language-independent)
+ commandLine 'icacls', "$buildDir\\image\\legal", '/grant', "${usersGroup}:(OI)(CI)F", '/T'
} else {
commandLine 'chmod', '-R', 'u+w', "$buildDir/image/legal"
}
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.