improve appearance of app notifications after controlsfx upgrade
What the developer wrote
Authored by Craig Raw
improve appearance of app notifications after controlsfx upgrade
What changed, and why it matters
This commit is a purely cosmetic tweak to how pop-up notification windows look in the Sparrow Wallet app after a user-interface library upgrade. It adds a CSS style class and adjusts spacing, padding, and minimum height so notifications display correctly. There is no security-relevant change.
No security action needed; treat as routine UI polish.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies DialogImage.java to add the ‘dialog-image’ CSS style class to a custom JavaFX control, and updates notificationpopup.css to set a minimum pane height, reduce translate-y offsets for title and text labels, and apply a negative translate-y to the new dialog-image class. These are layout/styling adjustments following a ControlsFX upgrade; no code paths, permissions, cryptography, network handling, or data processing are changed.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/DialogImage.javasrc/main/resources/com/sparrowwallet/sparrow/notificationpopup.cssInspect captured patch +8 / −2
diff --git a/src/main/java/com/sparrowwallet/sparrow/control/DialogImage.java b/src/main/java/com/sparrowwallet/sparrow/control/DialogImage.java
index 3f837d0..9a5d43c 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/DialogImage.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/DialogImage.java
@@ -24,6 +24,7 @@ public class DialogImage extends StackPane {
public ObjectProperty<DialogImage.Type> typeProperty = new SimpleObjectProperty<>();
public DialogImage() {
+ getStyleClass().add("dialog-image");
setPrefSize(WIDTH, HEIGHT);
this.typeProperty.addListener((observable, oldValue, type) -> {
refresh(type);
diff --git a/src/main/resources/com/sparrowwallet/sparrow/notificationpopup.css b/src/main/resources/com/sparrowwallet/sparrow/notificationpopup.css
index 9cfcc69..e83876c 100644
--- a/src/main/resources/com/sparrowwallet/sparrow/notificationpopup.css
+++ b/src/main/resources/com/sparrowwallet/sparrow/notificationpopup.css
@@ -1,6 +1,7 @@
.notification-bar > .pane {
-fx-padding: 0 7 7 7;
+ -fx-min-height: 80;
}
.notification-bar .close-button {
@@ -11,7 +12,7 @@
-fx-font-size: 15px;
-fx-text-fill: -fx-text-inner-color;
-fx-padding: 5 0 0 68;
- -fx-translate-y: 10;
+ -fx-translate-y: 5;
}
.notification-bar > .pane .label {
@@ -22,6 +23,10 @@
-fx-graphic-text-gap: 8;
}
+.notification-bar > .pane .label .dialog-image {
+ -fx-translate-y: -10;
+}
+
.notification-bar > .pane .label .text {
- -fx-translate-y: 12;
+ -fx-translate-y: 6;
}
\ No newline at end of file
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.