list payments to other addresses in the summary of a transaction paying premix outputs
What changed, and why it matters
This commit fixes a UI labeling bug in Sparrow Wallet's transaction diagram. When a transaction included Whirlpool premix outputs, the summary was only showing the premix-related outputs and hiding any ordinary payments sent to other addresses. The change makes those other payments visible again in the transaction summary, so users do not mistakenly think they only sent funds to premix addresses.
No urgent security action required. Treat as a normal bug-fix release. Users who review transaction destinations before signing should verify they are on a version containing this fix, especially when creating transactions that include both premix and non-premix payments.
Security signals we found
UI misrepresentation of transaction outputs
potential user confusion about destination addresses in coinjoin/premix transactions
informational completeness fix for transaction summary
Evidence from the diff
TransactionDiagramLabel.update() previously added labels for premix outputs, Whirlpool fee outputs, and badbank outputs when a transaction was detected as a premix send. It did not label remaining payment outputs that were not premix, not Whirlpool fees, and not badbank. The patch adds a loop over walletTx.getOutputs() that calls transactionDiagram.isPaymentAndNotChange(output), resolves the Payment from either a PaymentOutput or ConsolidationOutput, and if it is not a premix send, not a Whirlpool fee, and not a badbank send, adds a normal output label. This is a display-only correction; no transaction construction, signing, or validation logic is changed.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagramLabel.javaInspect captured patch +10 / −0
### src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagramLabel.java
@@ -87,6 +87,16 @@ public void update(TransactionDiagram transactionDiagram) {
List<Payment> badbankOutputs = walletTx.getPayments().stream().filter(walletTx::isBadbankSend).collect(Collectors.toList());
List<OutputLabel> badbankOutputLabels = badbankOutputs.stream().map(payment -> getBadbankOutputLabel(transactionDiagram, payment)).collect(Collectors.toList());
outputLabels.addAll(badbankOutputLabels);
+
+ for(WalletTransaction.Output output : walletTx.getOutputs()) {
+ if(transactionDiagram.isPaymentAndNotChange(output)) {
+ Payment payment = output instanceof WalletTransaction.PaymentOutput po ? po.getPayment()
+ : ((WalletTransaction.ConsolidationOutput)output).getWalletNodePayment();
+ if(!walletTx.isPremixSend(payment) && payment.getType() != Payment.Type.WHIRLPOOL_FEE && !walletTx.isBadbankSend(payment)) {
+ outputLabels.add(getOutputLabel(transactionDiagram, output));
+ }
+ }
+ }
} else if(walletTx.getPayments().size() >= 5 && walletTx.getPayments().stream().mapToLong(Payment::getAmount).distinct().count() <= 1 && walletTx.getWallet() != null
&& walletTx.getWallet().getStandardAccountType() == StandardAccount.WHIRLPOOL_PREMIX && walletTx.getPayments().stream().anyMatch(walletTx::isPostmixSend)) {
OutputLabel mixOutputLabel = getMixOutputLabel(transactionDiagram, walletTx.getPayments());Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.