support loading v3 transactions in the transaction editor
What the developer wrote
Authored by Craig Raw
support loading v3 transactions in the transaction editor
What changed, and why it matters
This commit simply allows Sparrow Wallet's transaction editor to display and edit Bitcoin transactions that use version number 3, in addition to versions 1 and 2. It is a routine compatibility update with no apparent security relevance.
No security action required. Review as part of normal release testing for v3 transaction handling.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change widens the accepted range of the transaction version spinner in HeadersController.java from [1,2] to [1,3]. This enables the UI to load and edit v3 transactions (e.g., those using BIP-431 topology restrictions) without rejecting the version field as out of range. No other logic is modified.
Changed components
src/main/java/com/sparrowwallet/sparrow/transaction/HeadersController.javaInspect captured patch +2 / −2
diff --git a/src/main/java/com/sparrowwallet/sparrow/transaction/HeadersController.java b/src/main/java/com/sparrowwallet/sparrow/transaction/HeadersController.java
index 400d07e..8e83e07 100644
--- a/src/main/java/com/sparrowwallet/sparrow/transaction/HeadersController.java
+++ b/src/main/java/com/sparrowwallet/sparrow/transaction/HeadersController.java
@@ -280,9 +280,9 @@ public class HeadersController extends TransactionFormController implements Init
updateTxId();
- version.setValueFactory(new IntegerSpinner.ValueFactory(1, 2, (int)tx.getVersion()));
+ version.setValueFactory(new IntegerSpinner.ValueFactory(1, 3, (int)tx.getVersion()));
version.valueProperty().addListener((obs, oldValue, newValue) -> {
- if(newValue == null || newValue < 1 || newValue > 2) {
+ if(newValue == null || newValue < 1 || newValue > 3) {
return;
}
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.