report fee rates from the fee slider, name the blocks slider and receive QR codes, and stop exposing address chunks to screen readers
What changed, and why it matters
This commit improves accessibility for users who rely on screen readers. It makes the fee slider, block target slider, and QR codes announce their purpose correctly, and stops screen readers from reading out Bitcoin addresses as separate visual chunks (which could confuse or leak address fragments). There is no direct security vulnerability being patched—this is a usability and minor privacy-hardening change.
No urgent action required. Treat as a normal accessibility/usability improvement. If desired, verify with a screen reader that addresses are read once as a whole and that fee-rate values are announced correctly.
Security signals we found
Accessibility API now hides chunked address Text nodes from screen readers
Fee slider reports real fee-rate values to assistive technologies instead of internal logarithmic positions
QR code images and block-target slider receive descriptive accessible names
Evidence from the diff
The patch modifies JavaFX accessibility attributes. Address display skins now return an empty child list for AccessibleAttribute.CHILDREN and set AccessibleRole.NODE, preventing assistive technologies from enumerating the chunked visual Text nodes that render grouped address characters. The FeeRangeSlider now reports actual fee rates (sats/vB) instead of its internal logarithmic slider value, and accepts SET_VALUE actions in fee-rate units. The target-blocks Slider and QR-code ImageViews receive accessibleText labels. These are accessibility improvements with a small side benefit of reducing address-fragment exposure to assistive software.
Changed components
AddressLabelSkinAddressTextFieldSkinAddressTreeTableCellSkinFeeRangeSliderSendControllerreceive.fxmlsend.fxmlInspect captured patch +61 / −18
### src/main/java/com/sparrowwallet/sparrow/control/AddressLabelSkin.java
@@ -2,7 +2,10 @@
import com.sparrowwallet.drongo.Network;
import javafx.beans.value.ChangeListener;
+import javafx.collections.FXCollections;
import javafx.geometry.Insets;
+import javafx.scene.AccessibleAttribute;
+import javafx.scene.AccessibleRole;
import javafx.scene.Node;
import javafx.scene.control.ContentDisplay;
import javafx.scene.control.Label;
@@ -27,10 +30,7 @@ public class AddressLabelSkin extends LabelSkin {
public AddressLabelSkin(Label control) {
super(control);
- displayFlow = new TextFlow();
- displayFlow.setManaged(false);
- displayFlow.setMouseTransparent(true);
-
+ displayFlow = createDisplayFlow();
getChildren().addFirst(displayFlow);
textListener = (_, _, newText) -> updateDisplay(newText);
@@ -42,6 +42,24 @@ public AddressLabelSkin(Label control) {
control.setStyle("-fx-text-fill: transparent;");
}
+ static TextFlow createDisplayFlow() {
+ //Drawn over the control's own transparent text, which screen readers already read
+ TextFlow displayFlow = new TextFlow() {
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ if(attribute == AccessibleAttribute.CHILDREN) {
+ return FXCollections.emptyObservableList();
+ }
+
+ return super.queryAccessibleAttribute(attribute, parameters);
+ }
+ };
+ displayFlow.setAccessibleRole(AccessibleRole.NODE);
+ displayFlow.setManaged(false);
+ displayFlow.setMouseTransparent(true);
+ return displayFlow;
+ }
+
@Override
public void dispose() {
getSkinnable().textProperty().removeListener(textListener);
### src/main/java/com/sparrowwallet/sparrow/control/AddressTextFieldSkin.java
@@ -36,9 +36,7 @@ public class AddressTextFieldSkin extends CustomTextFieldSkin {
public AddressTextFieldSkin(TextField control) {
super(control);
- displayFlow = new TextFlow();
- displayFlow.setManaged(false);
- displayFlow.setMouseTransparent(true);
+ displayFlow = AddressLabelSkin.createDisplayFlow();
clip = new Rectangle();
displayFlow.setClip(clip);
### src/main/java/com/sparrowwallet/sparrow/control/AddressTreeTableCellSkin.java
@@ -17,9 +17,7 @@ public class AddressTreeTableCellSkin<S, T> extends TreeTableCellSkin<S, T> {
public AddressTreeTableCellSkin(TreeTableCell<S, T> cell) {
super(cell);
- displayFlow = new TextFlow();
- displayFlow.setManaged(false);
- displayFlow.setMouseTransparent(true);
+ displayFlow = AddressLabelSkin.createDisplayFlow();
displayFlow.setMinWidth(Region.USE_PREF_SIZE);
getChildren().add(displayFlow);
### src/main/java/com/sparrowwallet/sparrow/control/FeeRangeSlider.java
@@ -4,6 +4,8 @@
import com.sparrowwallet.sparrow.AppServices;
import com.sparrowwallet.sparrow.net.FeeRatesSource;
import javafx.application.Platform;
+import javafx.scene.AccessibleAction;
+import javafx.scene.AccessibleAttribute;
import javafx.scene.Node;
import javafx.scene.control.Slider;
import javafx.util.StringConverter;
@@ -27,6 +29,7 @@ public FeeRangeSlider() {
setShowTickLabels(true);
setShowTickMarks(true);
setBlockIncrement(Math.log(1.02) / Math.log(2));
+ setAccessibleText("Fee Rate (sats/vB)");
setLabelFormatter(new StringConverter<>() {
@Override
@@ -70,18 +73,22 @@ public double getFeeRate() {
}
public double getFeeRate(Double minRelayFeeRate) {
+ return getFeeRate(getValue(), minRelayFeeRate);
+ }
+
+ private double getFeeRate(double value, Double minRelayFeeRate) {
if(minRelayFeeRate >= Transaction.DEFAULT_MIN_RELAY_FEE) {
- return Math.pow(2.0, getValue());
+ return Math.pow(2.0, value);
}
- if(getValue() < 1.0d) {
+ if(value < 1.0d) {
if(minRelayFeeRate == 0.0d) {
- return getValue();
+ return value;
}
- return Math.pow(minRelayFeeRate, 1.0d - getValue());
+ return Math.pow(minRelayFeeRate, 1.0d - value);
}
- return Math.pow(2.0, getValue() - 1.0d);
+ return Math.pow(2.0, value - 1.0d);
}
public void setFeeRate(double feeRate) {
@@ -137,6 +144,26 @@ private void updateMaxFeeRange(double value) {
}
}
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ //Report fee rates rather than the logarithmic slider position
+ return switch(attribute) {
+ case VALUE -> Math.round(getFeeRate() * 1000) / 1000.0;
+ case MIN_VALUE -> getFeeRate(getMin(), AppServices.getMinimumRelayFeeRate());
+ case MAX_VALUE -> getFeeRate(getMax(), AppServices.getMinimumRelayFeeRate());
+ default -> super.queryAccessibleAttribute(attribute, parameters);
+ };
+ }
+
+ @Override
+ public void executeAccessibleAction(AccessibleAction action, Object... parameters) {
+ if(action == AccessibleAction.SET_VALUE && parameters.length > 0 && parameters[0] instanceof Double feeRate) {
+ setFeeRate(Math.clamp(feeRate, AppServices.getLongFeeRatesRange().getFirst(), AppServices.getLongFeeRatesRange().getLast()));
+ } else {
+ super.executeAccessibleAction(action, parameters);
+ }
+ }
+
public boolean isLongFeeRange() {
return getMax() > AppServices.getFeeRatesRange().size() - 1;
}
### src/main/java/com/sparrowwallet/sparrow/wallet/SendController.java
@@ -208,6 +208,7 @@ public void changed(ObservableValue<? extends Number> observable, Number oldValu
Tooltip tooltip = new Tooltip("Target inclusion within " + target + " blocks");
targetBlocks.setTooltip(tooltip);
+ targetBlocks.setAccessibleText(tooltip.getText());
userFeeSet.set(false);
for(Tab tab : paymentTabs.getTabs()) {
@@ -841,6 +842,7 @@ private void setTargetBlocks(Integer target) {
blockTargetFeeRatesChart.select(target);
Tooltip tooltip = new Tooltip("Target inclusion within " + target + " blocks");
targetBlocks.setTooltip(tooltip);
+ targetBlocks.setAccessibleText(tooltip.getText());
targetBlocks.valueProperty().addListener(targetBlocksListener);
}
### src/main/resources/com/sparrowwallet/sparrow/wallet/receive.fxml
@@ -50,7 +50,7 @@
</Form>
<AnchorPane fx:id="qrCodePane" GridPane.columnIndex="1" GridPane.rowIndex="0">
- <ImageView fx:id="qrCode" styleClass="qr-code" AnchorPane.rightAnchor="5"/>
+ <ImageView fx:id="qrCode" accessibleText="Address QR Code" styleClass="qr-code" AnchorPane.rightAnchor="5"/>
</AnchorPane>
<Form fx:id="spReceiveForm" GridPane.columnIndex="0" GridPane.rowIndex="0">
@@ -104,7 +104,7 @@
<Form fx:id="spQrForm" GridPane.columnIndex="0" GridPane.rowIndex="2" alignment="CENTER">
<Fieldset inputGrow="SOMETIMES" text="">
<Field text="">
- <ImageView fx:id="spQrCode" styleClass="qr-code" />
+ <ImageView fx:id="spQrCode" accessibleText="Silent Payments Address QR Code" styleClass="qr-code" />
</Field>
</Fieldset>
</Form>
### src/main/resources/com/sparrowwallet/sparrow/wallet/send.fxml
@@ -95,7 +95,7 @@
<Form GridPane.columnIndex="0" GridPane.rowIndex="2">
<Fieldset inputGrow="SOMETIMES">
<Field fx:id="targetBlocksField" text="Blocks:">
- <Slider fx:id="targetBlocks" snapToTicks="true" showTickLabels="true" showTickMarks="true" />
+ <Slider fx:id="targetBlocks" accessibleText="Target Blocks" snapToTicks="true" showTickLabels="true" showTickMarks="true" />
</Field>
<Field fx:id="feeRangeField" text="Range:">
<FeeRangeSlider fx:id="feeRange" />Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.