Merge pull request #186 from MAGICGrants/misc-fixes
What changed, and why it matters
This commit is a routine maintenance update. It adds a small notification icon for Android status-bar alerts, swaps a duplicated date-grouping code block for a shared helper, and updates several internal wallet-core library dependencies to a newer commit. There is nothing in the changes that fixes a security vulnerability or introduces a known risky behavior.
No security action required. Treat as a normal dependency and UI polish update. If desired, review the wallet-core commit c69fffd03898046070fc800c1325525eab7d624f changelog for any unrelated fixes, but this commit itself does not indicate security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff shows three categories of changes: (1) Android notification branding—new drawable PNGs and AndroidManifest.xml meta-data pointing to ic_stat_skylight, plus wiring in wallet_core_glue.dart that sets NotificationService.androidSmallIcon and BackgroundSync.foregroundIcon; (2) a small UI refactor in wallet_home.dart replacing an inline day-header flattening loop with a shared withDayHeaders helper; and (3) pubspec.yaml/lock updates bumping MAGICGrants/wallet-core git refs from 28eceed0 to c69fffd0 across wallet_infra, wallet_domain, wallet_monero, wallet_openalias, wallet_background, wallet_fiat, and wallet_ui. No security-relevant code paths (cryptography, network trust, permissions, exported components, input validation, etc.) are modified.
Changed components
AndroidManifest.xmllib/wallet_core_glue.dartlib/screens/wallet_home.dartpubspec.yamlpubspec.lockwallet-core git dependenciesInspect captured patch +33 / −34
### android/app/src/main/AndroidManifest.xml
@@ -21,6 +21,10 @@
android:name="com.google.firebase.messaging.default_notification_channel_id"
android:value="incoming_transactions"/>
+ <meta-data
+ android:name="org.magicgrants.skylightwallet.notification_icon"
+ android:resource="@drawable/ic_stat_skylight"/>
+
<receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ActionBroadcastReceiver" />
<receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ScheduledNotificationReceiver" />
<receiver android:exported="false" android:name="com.dexterous.flutterlocalnotifications.ScheduledNotificationBootReceiver">
### android/app/src/main/res/drawable-hdpi/ic_stat_skylight.png
[binary or diff unavailable]
### android/app/src/main/res/drawable-mdpi/ic_stat_skylight.png
[binary or diff unavailable]
### android/app/src/main/res/drawable-xhdpi/ic_stat_skylight.png
[binary or diff unavailable]
### android/app/src/main/res/drawable-xxhdpi/ic_stat_skylight.png
[binary or diff unavailable]
### android/app/src/main/res/drawable-xxxhdpi/ic_stat_skylight.png
[binary or diff unavailable]
### lib/screens/wallet_home.dart
@@ -411,18 +411,7 @@ class _ActivitySliver extends StatelessWidget {
);
}
- // Flatten into day-header strings interleaved with tx entries (matches Spice).
- final rows = <Object>[];
- DateTime? lastDay;
- for (final tx in txs) {
- final d = DateTime.fromMillisecondsSinceEpoch(tx.timestamp * 1000);
- final day = DateTime(d.year, d.month, d.day);
- if (day != lastDay) {
- rows.add(DateFormat('d MMMM').format(day).toUpperCase());
- lastDay = day;
- }
- rows.add(tx);
- }
+ final rows = withDayHeaders(txs, (tx) => tx.timestamp);
return SliverPadding(
padding: EdgeInsets.symmetric(horizontal: horizontalPadding),
### lib/wallet_core_glue.dart
@@ -17,7 +17,7 @@ import 'package:skylight_wallet/services/tor_service.dart';
import 'package:skylight_wallet/services/tor_settings_service.dart';
import 'package:wallet_infra/wallet_infra.dart' as wcore;
-import 'package:wallet_background/wallet_background.dart' show BackgroundSync;
+import 'package:wallet_background/wallet_background.dart' show BackgroundSync, NotificationIcon;
import 'package:wallet_fiat/wallet_fiat.dart' show FiatRates;
import 'package:wallet_domain/wallet_domain.dart'
show
@@ -50,6 +50,8 @@ void installWalletCore() {
wcore.NotificationService.windowsAppName = 'Skylight Wallet';
wcore.NotificationService.windowsAppUserModelId = 'org.magicgrants.skylight';
wcore.NotificationService.windowsGuid = '6dcf17a9-fb5f-4f47-b0b9-6d655e90adbf';
+ // Same status-bar mark as the continuous-sync foreground-service notification.
+ wcore.NotificationService.androidSmallIcon = 'ic_stat_skylight';
BackgroundSync.install(
coins: () => [MoneroWallet()],
@@ -58,6 +60,10 @@ void installWalletCore() {
ensureTorConnected: _ensureTorConnected,
iosBundleId: 'org.magicgrants.skylightwallet',
foregroundTitle: 'Skylight Wallet',
+ foregroundIcon: const NotificationIcon(
+ metaDataName: 'org.magicgrants.skylightwallet.notification_icon',
+ backgroundColor: Color(0xFFF5681C),
+ ),
);
FiatRates.install(getTorProxy: TorSettingsService.sharedInstance.getProxy);
### pubspec.lock
@@ -1264,62 +1264,62 @@ packages:
dependency: "direct main"
description:
path: "packages/wallet_background"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_domain:
dependency: "direct main"
description:
path: "packages/wallet_domain"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_fiat:
dependency: "direct main"
description:
path: "packages/wallet_fiat"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_infra:
dependency: "direct main"
description:
path: "packages/wallet_infra"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_monero:
dependency: "direct main"
description:
path: "packages/wallet_monero"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_openalias:
dependency: "direct main"
description:
path: "packages/wallet_openalias"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_ui:
dependency: "direct main"
description:
path: "packages/wallet_ui"
- ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
- resolved-ref: "28eceed05227d3cd8100c890cbdc50e3ac6116fd"
+ ref: c69fffd03898046070fc800c1325525eab7d624f
+ resolved-ref: c69fffd03898046070fc800c1325525eab7d624f
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
### pubspec.yaml
@@ -65,37 +65,37 @@ dependencies:
wallet_infra:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_infra
wallet_domain:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_domain
wallet_monero:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_monero
wallet_openalias:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_openalias
wallet_background:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_background
wallet_fiat:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_fiat
wallet_ui:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 28eceed05227d3cd8100c890cbdc50e3ac6116fd
+ ref: c69fffd03898046070fc800c1325525eab7d624f
path: packages/wallet_ui
bip39:Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.