New libwallet2 builds and a few tweaks
What the developer wrote
Authored by Keeqler
New libwallet2 builds and a few tweaks
What changed, and why it matters
This commit updates pre-built Monero wallet library files, fixes leftover Git merge-conflict markers in the app's startup code, and limits a custom certificate-file workaround to Android only. The merge-conflict cleanup is a routine code tidying change. The certificate change means non-Android platforms will now rely on normal system certificate verification instead of a bundled certificate file, which is generally a good thing but could affect connection behavior. The library updates are opaque binary changes whose security implications cannot be judged from the diff alone.
Because the native library binaries changed without source-level diff, reviewers should request the corresponding source commit/change log for monero_c / libwallet2 and confirm the binaries were built reproducibly from that source. Verify the new Git dependency resolves to a known-good, signed or audited commit. Treat this as a supply-chain checkpoint until provenance is confirmed.
Security signals we found
Rebuilt native wallet libraries without visible source diff
Dependency switched from local path to Git reference (vtnerd/monero_c)
Merge-conflict marker cleanup in lib/main.dart
Platform-gated custom CA certificate loading
Evidence from the diff
The commit changes three binary shared objects (libmonero_libwallet2_api_c.so for Android arm64/x86_64 and Linux), cleans up Git conflict markers in lib/main.dart, and modifies wallet_model.dart so getCacertFile()/setCaFilePath() is only called on Android. pubspec.lock switches the monero.dart dependency from a local path to a Git reference (vtnerd/monero_c, ref lwsf). No source code for the rebuilt native libraries is shown, so we cannot verify what changed in libwallet2.
Changed components
android/app/src/main/jniLibs/arm64-v8a/libmonero_libwallet2_api_c.soandroid/app/src/main/jniLibs/x86_64/libmonero_libwallet2_api_c.solinux/monero_libwallet2_api_c.solib/main.dartlib/models/wallet_model.dartpubspec.lockInspect captured patch +14 / −17
diff --git a/android/app/src/main/jniLibs/arm64-v8a/libmonero_libwallet2_api_c.so b/android/app/src/main/jniLibs/arm64-v8a/libmonero_libwallet2_api_c.so
index 3fa8898..266c90d 100755
Binary files a/android/app/src/main/jniLibs/arm64-v8a/libmonero_libwallet2_api_c.so and b/android/app/src/main/jniLibs/arm64-v8a/libmonero_libwallet2_api_c.so differ
diff --git a/android/app/src/main/jniLibs/x86_64/libmonero_libwallet2_api_c.so b/android/app/src/main/jniLibs/x86_64/libmonero_libwallet2_api_c.so
index a6228b6..2a30b47 100755
Binary files a/android/app/src/main/jniLibs/x86_64/libmonero_libwallet2_api_c.so and b/android/app/src/main/jniLibs/x86_64/libmonero_libwallet2_api_c.so differ
diff --git a/lib/main.dart b/lib/main.dart
index ec0ef39..9f941ed 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -1,18 +1,8 @@
import 'dart:io';
import 'package:flutter/material.dart';
-<<<<<<< HEAD
-=======
-import 'package:skylight_wallet/periodic_tasks.dart';
-import 'package:skylight_wallet/screens/privacy_policy.dart';
-import 'package:skylight_wallet/screens/terms_of_service.dart';
-import 'package:skylight_wallet/screens/unlock.dart';
-import 'package:skylight_wallet/services/notifications_service.dart';
-import 'package:skylight_wallet/services/shared_preferences_service.dart';
->>>>>>> main
import 'package:provider/provider.dart';
import 'package:shared_preferences/shared_preferences.dart';
-import 'package:skylight_wallet/util/dirs.dart';
import 'package:timeago/timeago.dart' as timeago;
import 'package:skylight_wallet/models/fiat_rate_model.dart';
@@ -39,12 +29,14 @@ import 'package:skylight_wallet/screens/restore_warning.dart';
import 'package:skylight_wallet/screens/wallet_home.dart';
import 'package:skylight_wallet/screens/welcome.dart';
import 'package:skylight_wallet/screens/address_book.dart';
-import 'package:skylight_wallet/util/logging.dart';
-import 'package:skylight_wallet/periodic_tasks.dart';
import 'package:skylight_wallet/screens/privacy_policy.dart';
import 'package:skylight_wallet/screens/terms_of_service.dart';
import 'package:skylight_wallet/screens/unlock.dart';
+import 'package:skylight_wallet/services/notifications_service.dart';
import 'package:skylight_wallet/services/shared_preferences_service.dart';
+import 'package:skylight_wallet/periodic_tasks.dart';
+import 'package:skylight_wallet/util/dirs.dart';
+import 'package:skylight_wallet/util/logging.dart';
import 'package:skylight_wallet/util/cacert.dart';
final isDesktop = Platform.isLinux || Platform.isWindows || Platform.isMacOS;
diff --git a/lib/models/wallet_model.dart b/lib/models/wallet_model.dart
index 2a086aa..a78697a 100644
--- a/lib/models/wallet_model.dart
+++ b/lib/models/wallet_model.dart
@@ -363,8 +363,11 @@ class WalletModel with ChangeNotifier {
final proxyPort = torProxyPort ?? _connectionProxyPort;
- final cacertFile = await getCacertFile();
- _w2Wallet!.setCaFilePath(cacertFile.path);
+ if (Platform.isAndroid) {
+ // This addresses SSL certificate verification issues on Android
+ final cacertFile = await getCacertFile();
+ _w2Wallet!.setCaFilePath(cacertFile.path);
+ }
await _connectToDaemon(
address: _connectionAddress,
diff --git a/linux/monero_libwallet2_api_c.so b/linux/monero_libwallet2_api_c.so
index 5357e8b..6094274 100755
Binary files a/linux/monero_libwallet2_api_c.so and b/linux/monero_libwallet2_api_c.so differ
diff --git a/pubspec.lock b/pubspec.lock
index 6fe190a..0832232 100644
--- a/pubspec.lock
+++ b/pubspec.lock
@@ -464,9 +464,11 @@ packages:
monero:
dependency: "direct main"
description:
- path: "../monero_c/impls/monero.dart"
- relative: true
- source: path
+ path: "impls/monero.dart"
+ ref: lwsf
+ resolved-ref: b66c72f7a923c32021b0b52a5a572c0b8be3c782
+ url: "https://github.com/vtnerd/monero_c"
+ source: git
version: "0.0.0"
nested:
dependency: transitive
Why this scored 29/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.