What changed, and why it matters
This commit fixes the automated testing pipeline for TLS-related checks across Android, iOS, Linux, and Windows. It adds a 45-minute timeout to jobs, replaces a potentially hanging display-server helper with a more reliable manual startup, and updates a test so it creates a temporary app directory instead of relying on the real app startup. There is no direct evidence this fixes a security vulnerability in the shipped wallet; it appears to be a reliability and test-correctness change.
No immediate security action required. Treat as routine CI/test maintenance. If reviewing for release readiness, verify the native TLS integration tests now pass consistently across all platforms.
Security signals we found
Workflow reliability improvement (timeout, Xvfb startup hang mitigation)
Test fixture isolation (temporary directory, config reset)
TLS-related test file touched, but no TLS implementation code changed
Evidence from the diff
The diff touches two files: a GitHub Actions workflow and an integration test. Workflow changes: add timeout-minutes: 45 to android, ios, linux, and windows jobs; replace xvfb-run with a manual Xvfb start plus a poll loop for /tmp/.X11-unix/X99; pass TEST and DEBIAN_FRONTEND=noninteractive into the Docker container; use bash -euo pipefail. Test changes: import wallet_domain and wallet_infra/testing; create a temp directory, install a fixed WalletAppConfig for Skylight, run checkShippedCaBundle(), then reset config and delete temp dir. The stated reason is that the test does not run main(), so the real app directory is not set up.
Changed components
.github/workflows/native-tls.ymlintegration_test/native_tls_test.dartInspect captured patch +33 / −2
### .github/workflows/native-tls.yml
@@ -38,6 +38,7 @@ jobs:
android:
name: Android (emulator)
+ timeout-minutes: 45
runs-on: ubuntu-latest
needs: flutter-version
steps:
@@ -80,6 +81,7 @@ jobs:
ios:
name: iOS (simulator)
+ timeout-minutes: 45
runs-on: macos-26
needs: flutter-version
steps:
@@ -123,6 +125,7 @@ jobs:
linux:
name: Linux
+ timeout-minutes: 45
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
@@ -131,16 +134,31 @@ jobs:
- name: Pull builder image
run: docker pull ghcr.io/magicgrants/skylight-wallet-builder:latest
+ # The display server is started directly rather than through xvfb-run,
+ # which waits for a ready signal from it and can wait forever in a
+ # container.
- name: Native TLS checks
run: |
docker run --rm \
-v "$PWD:/workspace" \
-w /workspace \
+ -e TEST \
+ -e DEBIAN_FRONTEND=noninteractive \
ghcr.io/magicgrants/skylight-wallet-builder:latest \
- bash -c "apt-get update && apt-get install -y --no-install-recommends xvfb xauth && flutter pub get --enforce-lockfile && bash scripts/pin-rust-toolchain.sh && xvfb-run -a flutter test $TEST -d linux"
+ bash -euo pipefail -c '
+ apt-get update
+ apt-get install -y --no-install-recommends xvfb
+ flutter pub get --enforce-lockfile
+ bash scripts/pin-rust-toolchain.sh
+ Xvfb :99 -screen 0 1280x1024x24 -nolisten tcp -ac &
+ for _ in $(seq 50); do [ -S /tmp/.X11-unix/X99 ] && break; sleep 0.2; done
+ [ -S /tmp/.X11-unix/X99 ] || { echo "Xvfb did not start" >&2; exit 1; }
+ DISPLAY=:99 flutter test "$TEST" -d linux
+ '
windows:
name: Windows
+ timeout-minutes: 45
runs-on: windows-2022
needs: flutter-version
steps:
### integration_test/native_tls_test.dart
@@ -2,6 +2,8 @@ import 'dart:io';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
+import 'package:wallet_domain/wallet_domain.dart';
+import 'package:wallet_infra/testing.dart';
import 'package:wallet_monero/testing.dart';
/// TLS against the native library this app ships, on the platform the test
@@ -13,7 +15,18 @@ import 'package:wallet_monero/testing.dart';
void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
- testWidgets('the shipped CA bundle reaches the app directory', (_) => checkShippedCaBundle());
+ testWidgets('the shipped CA bundle reaches the app directory', (_) async {
+ // The app sets up its directory in main(), which this test does not run,
+ // so a temporary directory stands in for it.
+ final dir = await Directory.systemTemp.createTemp('ca_bundle');
+ WalletAppConfig.install(WalletAppConfig.skylight, directories: FixedDirectories(dir));
+ try {
+ await checkShippedCaBundle();
+ } finally {
+ WalletAppConfig.resetForTesting();
+ await dir.delete(recursive: true);
+ }
+ });
for (final check in nativeTlsChecks()) {
testWidgets(check.name, (_) async {Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.