What changed, and why it matters
This commit updates the Flutter framework, Dart SDK, Tor plugin, Kotlin, Gradle, and related build tooling to newer versions. It also makes small code changes: one fixes a timing bug where an OpenAlias lookup result was used before it was ready, and another removes an unused local variable. The main security angle is routine dependency updates (which may include upstream bug and security fixes) plus one minor correctness fix in address resolution. There is no explicit security bug or exploit described in the commit itself.
Treat as a routine maintenance update. Review upstream release notes for Flutter 3.47.7, Dart 3.13.5, the cypherstack/tor commit e30ed0d3, Kotlin 2.3.21, and Gradle 8.14.6 for any security advisories. Verify reproducible builds still pass after the toolchain changes. No immediate security patch or incident response is indicated by this commit alone.
Security signals we found
Dependency version bumps (Flutter, Dart, Tor plugin, Kotlin, Gradle, intl)
Tor plugin build path changed from cargokit to native-assets with its own pinned Rust toolchain
Minor async correctness fix: await _resolveInFlight! before returning in OpenAlias resolution
No explicit security issue, CVE, or exploit mentioned in commit message or diff
Evidence from the diff
The diff is primarily a maintenance/version-bump commit. Notable changes: Flutter 3.41.7 → 3.47.7, Dart SDK 3.11.5 → 3.13.5, tor_ffi_plugin ref c2706eeb → e30ed0d3, Kotlin 2.1.0 → 2.3.21, Gradle 8.13 → 8.14.6, intl 0.20.2 → 0.20.3. Build scripts now note that tor_ffi_plugin uses its own pinned Rust toolchain via a native-assets build hook instead of cargokit. Code changes: MoneroWalletAdapter constructor now assigns _readStoredSeed directly; SendScreen awaits an in-flight OpenAlias future before returning its result. analysis_options.yaml excludes all platform directories. No CVE, advisory, or vendor security disclosure is referenced.
Changed components
Flutter/Dart runtime environmenttor_ffi_plugin (Tor networking dependency)Android build toolchain (Kotlin, Gradle)lib/screens/send.dart (OpenAlias resolution)lib/models/monero_wallet_adapter.dart (constructor cleanup)CI/release build scriptsInspect captured patch +44 / −27
### .github/workflows/release.yml
@@ -282,9 +282,11 @@ jobs:
- name: Build Linux packages
run: |
- # cargokit builds the Rust plugins with `rustup run stable`, and the
+ # cargokit builds wallet_openalias with `rustup run stable`, and the
# image only has the rust-toolchain.toml version, so pin cargokit to it
# (as the Android job does) instead of downloading stable mid-build.
+ # tor_ffi_plugin's build hook uses its own pinned toolchain, which
+ # rustup downloads on first use.
VERSION='${{ needs.version.outputs.version }}'
docker run --rm \
-v "$PWD:/workspace" \
### .tool-versions
@@ -1 +1 @@
-flutter 3.41.7
+flutter 3.47.7
### README.md
@@ -85,8 +85,8 @@ A successful verification prints `Good signature from "MAGIC Grants <info@magicg
Before you begin, ensure you have the following installed:
-- **Flutter SDK** (3.41.7, the version pinned in `pubspec.yaml`) - [Installation guide](https://docs.flutter.dev/get-started/install)
-- **Dart SDK** (3.11.5) - Comes with Flutter
+- **Flutter SDK** (3.47.7, the version pinned in `pubspec.yaml`) - [Installation guide](https://docs.flutter.dev/get-started/install)
+- **Dart SDK** (3.13.5) - Comes with Flutter
- **Android Studio** - For Android development
- **Android SDK** - API level 24+ (Android 7.0 or higher)
- **Java JDK** - Version 17
### analysis_options.yaml
@@ -13,6 +13,13 @@ analyzer:
# Vendored/submodule code skylight consumes via pub-cache, not linted here.
exclude:
- monero_c/**
+ - build/**
+ - android/**
+ - ios/**
+ - web/**
+ - windows/**
+ - macos/**
+ - linux/**
linter:
# The lint rules applied to this project can be customized in the
### android/app/build.gradle.kts
@@ -44,10 +44,6 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}
- kotlinOptions {
- jvmTarget = JavaVersion.VERSION_17.toString()
- }
-
// One StoreReview or the other: Play's review flow, or a no-op.
sourceSets {
getByName("main") {
@@ -95,6 +91,12 @@ android {
}
}
+kotlin {
+ compilerOptions {
+ jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17
+ }
+}
+
val abiCodes = mapOf("armeabi-v7a" to 1, "arm64-v8a" to 2, "x86_64" to 3)
android.applicationVariants.configureEach {
val variant = this
### android/build.gradle.kts
@@ -41,8 +41,8 @@ subprojects {
}
}
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
- kotlinOptions {
- jvmTarget = JavaVersion.VERSION_17.toString()
+ compilerOptions {
+ jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17
}
}
}
### android/gradle.properties
@@ -1,4 +1,8 @@
org.gradle.jvmargs=-Xmx8G -XX:MaxMetaspaceSize=4G -XX:ReservedCodeCacheSize=512m -XX:+HeapDumpOnOutOfMemoryError
android.useAndroidX=true
android.enableJetifier=true
-(this@compileOptions).isCoreLibraryDesugaringEnabled=true
\ No newline at end of file
+(this@compileOptions).isCoreLibraryDesugaringEnabled=true
+# This builtInKotlin flag was added automatically by Flutter migrator
+android.builtInKotlin=false
+# This newDsl flag was added automatically by Flutter migrator
+android.newDsl=false
### android/gradle/wrapper/gradle-wrapper.properties
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.6-all.zip
### android/settings.gradle.kts
@@ -19,7 +19,7 @@ pluginManagement {
plugins {
id("dev.flutter.flutter-plugin-loader") version "1.0.0"
id("com.android.application") version "8.12.0" apply false
- id("org.jetbrains.kotlin.android") version "2.1.0" apply false
+ id("org.jetbrains.kotlin.android") version "2.3.21" apply false
}
include(":app")
### lib/l10n/app_localizations_en.dart
@@ -1,5 +1,6 @@
// ignore: unused_import
import 'package:intl/intl.dart' as intl;
+
import 'app_localizations.dart';
// ignore_for_file: type=lint
### lib/l10n/app_localizations_pt.dart
@@ -1,5 +1,6 @@
// ignore: unused_import
import 'package:intl/intl.dart' as intl;
+
import 'app_localizations.dart';
// ignore_for_file: type=lint
### lib/models/monero_wallet_adapter.dart
@@ -22,8 +22,7 @@ bool _deriveSsl(String address) =>
/// converting wallet-core types (BigInt amounts, TxDetails, connection details)
/// to skylight's. Re-fires the wrapped wallet's notifications.
class MoneroWalletAdapter extends ChangeNotifier implements AppWallet {
- MoneroWalletAdapter(this._wallet, {StoredSeedReader? readStoredSeed})
- : _readStoredSeed = readStoredSeed {
+ MoneroWalletAdapter(this._wallet, {this._readStoredSeed}) {
_wallet.addListener(notifyListeners);
}
### lib/screens/send.dart
@@ -280,7 +280,7 @@ class _SendScreenState extends State<SendScreen> {
// Someone may have resolved this exact alias while we were settling.
if (domain == _resolveCacheInput) return _resolveCacheOutput;
if (_resolveInFlight != null && domain == _resolveInFlightInput) {
- return _resolveInFlight!;
+ return await _resolveInFlight!;
}
// Only a real lookup is published as in-flight, so joining one always
### linux/flutter/generated_plugins.cmake
@@ -11,7 +11,6 @@ list(APPEND FLUTTER_PLUGIN_LIST
list(APPEND FLUTTER_FFI_PLUGIN_LIST
flutter_zxing
- tor_ffi_plugin
wallet_fhse
wallet_openalias
)
### pubspec.yaml
@@ -19,8 +19,8 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
version: 2.1.0+413
environment:
- sdk: 3.11.5
- flutter: 3.41.7
+ sdk: 3.13.5
+ flutter: 3.47.7
flutter_launcher_icons:
android: true
@@ -49,7 +49,7 @@ dependencies:
tor_ffi_plugin:
git:
url: https://github.com/cypherstack/tor
- ref: c2706eeb66174273a4a98113d7a8cd910ba124e6
+ ref: e30ed0d386a40ee4a999aeaf57aafd32921d601e
# The following adds the Cupertino Icons font to your application.
# Use with the CupertinoIcons class for iOS style icons.
@@ -126,7 +126,7 @@ dependencies:
dart_date: 1.5.3
qr_flutter: 4.1.0
share_plus: 11.1.0
- intl: 0.20.2
+ intl: 0.20.3
shared_preferences: 2.5.3
http: 1.6.0
workmanager: 0.9.0+3
### scripts/pin-rust-toolchain.sh
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
#
-# Pin cargokit's Rust toolchain for reproducible Rust-plugin builds (tor + openalias).
+# Pin cargokit's Rust toolchain for reproducible Rust-plugin builds (openalias).
#
# cargokit hardcodes the toolchain to "stable" and runs `rustup run stable cargo ...`
# — a MOVING channel, so the plugin would be built with whatever stable is latest at
@@ -9,9 +9,12 @@
# cargokit's config only allows the channel enum (stable/beta/nightly), not an exact
# version — so we patch the default in the package instead.
#
-# Both Rust plugins — tor_ffi_plugin and wallet_openalias — are git/pub
-# dependencies now, so their cargokit copies live in PUB_CACHE. We still scan the
-# in-repo plugins/ dir for any local path plugin, though there are none today.
+# wallet_openalias is a git dependency, so its cargokit copy lives in PUB_CACHE.
+# We still scan the in-repo plugins/ dir for any local path plugin, though there
+# are none today. tor_ffi_plugin no longer uses cargokit (since cypherstack/tor
+# native-0.2.0): its native-assets build hook builds with the toolchain pinned in
+# the package's own rust/rust-toolchain.toml and `cargo --locked`, and rustup
+# downloads that toolchain on first use.
#
# Run AFTER `flutter pub get` (so both packages are in PUB_CACHE) and BEFORE the
# flutter build. Idempotent; safe if the string is already pinned.
### scripts/repro/apk-repro-check.sh
@@ -91,7 +91,7 @@ docker run --rm \
export PUB_CACHE="$app/.pub-cache"
echo "==> [$app] flutter pub get..."
flutter pub get --enforce-lockfile
- echo "==> [$app] pinning cargokit toolchain (tor + openalias)..."
+ echo "==> [$app] pinning cargokit toolchain (openalias)..."
bash scripts/pin-rust-toolchain.sh
echo "==> [$app] flutter build apk (Rust + Dart AOT; slow, limited output)..."
flutter build apk --dart-define=DEMO_MODE=true --release --split-per-abi --target-platform="$PLATFORM"
### windows/flutter/generated_plugins.cmake
@@ -16,7 +16,6 @@ list(APPEND FLUTTER_PLUGIN_LIST
list(APPEND FLUTTER_FFI_PLUGIN_LIST
flutter_local_notifications_windows
flutter_zxing
- tor_ffi_plugin
wallet_fhse
wallet_openalias
)Why this scored 26/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.