Merge pull request #164 from MAGICGrants/moneroc-pin-update
What changed, and why it matters
This commit only updates version pins (commit hash references) for two external code libraries used by the Skylight Wallet app: monero_c and wallet-core. The actual code changes in those libraries are not shown in this commit. There is no description of any security fix, bug fix, or feature change. Based on this commit alone, we cannot determine whether the update fixes a security issue, introduces one, or is a routine maintenance change.
Review the changelogs and commit diffs for the updated monero_c commit de1f52cafd0e0ab7057e63994bc751af81f9ca76 and wallet-core commit 4285c22d6545d15a59d4762390e3e1f5593230a8 to determine whether this update addresses security issues. If either dependency fixes a vulnerability, assess whether the app needs an expedited release.
Security signals we found
Dependency pin update for wallet-core and monero_c
No security-relevant keywords in commit title or message
No code changes visible within the skylight-wallet repository
External submodule/package changes not reviewed in this diff
Evidence from the diff
The diff updates Git submodule and Dart pubspec references for MAGICGrants/monero_c (075265e… -> de1f52c…) and MAGICGrants/wallet-core (6860cbd… -> 4285c22…). No source code changes are present in the skylight-wallet repository itself. The commit message and title do not mention security, CVEs, vulnerabilities, or bug fixes. Without inspecting the referenced commits in the external repositories, no security classification can be made from this diff.
Changed components
monero_c submodule / Dart package referencewallet-core submodule / Dart package references (wallet_background, wallet_domain, wallet_fiat, wallet_infra, wallet_monero, wallet_openalias, wallet_ui)Inspect captured patch +25 / −25
### monero_c
@@ -1 +1 @@
-Subproject commit 075265e24bbf3628d6ce0407c7d1bb7945aa48e7
+Subproject commit de1f52cafd0e0ab7057e63994bc751af81f9ca76
### pubspec.lock
@@ -666,8 +666,8 @@ packages:
dependency: "direct main"
description:
path: "impls/monero.dart"
- ref: "075265e24bbf3628d6ce0407c7d1bb7945aa48e7"
- resolved-ref: "075265e24bbf3628d6ce0407c7d1bb7945aa48e7"
+ ref: de1f52cafd0e0ab7057e63994bc751af81f9ca76
+ resolved-ref: de1f52cafd0e0ab7057e63994bc751af81f9ca76
url: "https://github.com/magicgrants/monero_c"
source: git
version: "0.0.0"
@@ -1233,62 +1233,62 @@ packages:
dependency: "direct main"
description:
path: "packages/wallet_background"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_domain:
dependency: "direct main"
description:
path: "packages/wallet_domain"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_fiat:
dependency: "direct main"
description:
path: "packages/wallet_fiat"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_infra:
dependency: "direct main"
description:
path: "packages/wallet_infra"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_monero:
dependency: "direct main"
description:
path: "packages/wallet_monero"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_openalias:
dependency: "direct main"
description:
path: "packages/wallet_openalias"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
wallet_ui:
dependency: "direct main"
description:
path: "packages/wallet_ui"
- ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
- resolved-ref: "6860cbd8eaca4c2e1f9b1487ec8292592fdc205f"
+ ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
+ resolved-ref: "4285c22d6545d15a59d4762390e3e1f5593230a8"
url: "https://github.com/MAGICGrants/wallet-core"
source: git
version: "0.1.0"
### pubspec.yaml
@@ -57,45 +57,45 @@ dependencies:
monero:
git:
url: https://github.com/magicgrants/monero_c
- ref: 075265e24bbf3628d6ce0407c7d1bb7945aa48e7
+ ref: de1f52cafd0e0ab7057e63994bc751af81f9ca76
path: impls/monero.dart
# wallet-core packages; SHA-pinned for release, redirected to the local sibling
# clone by the gitignored pubspec_overrides.yaml for dev.
wallet_infra:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_infra
wallet_domain:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_domain
wallet_monero:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_monero
wallet_openalias:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_openalias
wallet_background:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_background
wallet_fiat:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_fiat
wallet_ui:
git:
url: https://github.com/MAGICGrants/wallet-core
- ref: 6860cbd8eaca4c2e1f9b1487ec8292592fdc205f
+ ref: 4285c22d6545d15a59d4762390e3e1f5593230a8
path: packages/wallet_ui
bip39:Why this scored 3/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.