What the developer wrote
Authored by Keeqler
Call refresh methods properly
What changed, and why it matters
This commit changes how a cryptocurrency wallet app refreshes its data. Previously, three refresh operations ran at the same time in separate background workers. Now they run one after another. The commit message simply says 'Call refresh methods properly.' There is no explicit security explanation in the commit or supplied references, so any security relevance is speculative. The change likely fixes a race condition or crash caused by concurrent access to the same wallet memory, which could in turn prevent inconsistent wallet state or denial-of-service for the user.
Treat this as a stability/correctness fix. If the app supports background refresh or auto-lock, review whether the refresh method can still be invoked concurrently from other code paths. Consider adding synchronization around the FFI pointer and auditing other Future.wait(...) calls that touch the same native wallet object. No emergency response is warranted absent a disclosed exploit.
Security signals we found
Concurrent FFI calls on shared native pointers replaced with sequential calls
Removal of Wallet_startRefresh from the refresh sequence
Pattern consistent with fixing a race condition or use-after-free/crash risk in wallet refresh
No explicit security claim in commit message or supplied references
Evidence from the diff
The patch removes a Future.wait(…) that concurrently executed monero.Wallet_startRefresh, monero.Wallet_refresh, and monero.TransactionHistory_refresh in separate Dart isolates, all passing the same wallet/history FFI pointers. It replaces them with sequential awaits: Wallet_refresh then TransactionHistory_refresh (Wallet_startRefresh is removed entirely). Concurrent FFI calls sharing the same pointer can race on the underlying C++ Monero wallet object, potentially causing memory corruption, crashes, or inconsistent wallet/transaction state. Serializing the calls and dropping startRefresh is a correctness fix. Without vendor disclosure, we cannot label it a confirmed vulnerability, but the pattern is a recognized source of instability.
Changed components
lib/models/wallet_model.dartWallet refresh logicMonero FFI bindings (Wallet_startRefresh, Wallet_refresh, TransactionHistory_refresh)Inspect captured patch +9 / −14
diff --git a/lib/models/wallet_model.dart b/lib/models/wallet_model.dart
index a6ca0fc..3f0c5dd 100644
--- a/lib/models/wallet_model.dart
+++ b/lib/models/wallet_model.dart
@@ -578,20 +578,15 @@ class WalletModel with ChangeNotifier {
'Calling Wallet_startRefresh, Wallet_refresh, and TransactionHistory_refresh',
);
- await Future.wait([
- Isolate.run(
- // ignore: deprecated_member_use
- () => monero.Wallet_startRefresh(Pointer.fromAddress(walletFfiAddr)),
- ),
- Isolate.run(
- // ignore: deprecated_member_use
- () => monero.Wallet_refresh(Pointer.fromAddress(walletFfiAddr)),
- ),
- Isolate.run(
- // ignore: deprecated_member_use
- () => monero.TransactionHistory_refresh(Pointer.fromAddress(historyFfiAddr)),
- ),
- ]);
+ await Isolate.run(
+ // ignore: deprecated_member_use
+ () => monero.Wallet_refresh(Pointer.fromAddress(walletFfiAddr)),
+ );
+
+ await Isolate.run(
+ // ignore: deprecated_member_use
+ () => monero.TransactionHistory_refresh(Pointer.fromAddress(historyFfiAddr)),
+ );
log(LogLevel.info, 'Wallet refresh methods completed successfully');
}
Why this scored 22/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.