What changed, and why it matters
This commit is a routine packaging and metadata update. It fixes how version numbers are handled in build scripts (allowing with or without a 'v' prefix), updates the application's version number from 1.0.4 to 1.0.5, and tweaks the package description and maintainer fields. There is no security-relevant change.
No security action required. Treat as a normal build/packaging maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies four files: appimage/build_appimage.sh, appimage/skylight_wallet.desktop, deb/build_deb.sh, and pubspec.yaml. The shell scripts now normalize the VERSION argument by stripping a leading ‘v’ and re-adding it only for output filenames, preventing mismatched package filenames. pubspec.yaml bumps the Flutter build version from 1.0.4+9 to 1.0.5+10. The .desktop and Debian control files update the comment/description strings and maintainer label. No code paths handling secrets, network, cryptography, permissions, or user input are changed.
Changed components
appimage/build_appimage.shappimage/skylight_wallet.desktopdeb/build_deb.shpubspec.yamlInspect captured patch +16 / −12
diff --git a/appimage/build_appimage.sh b/appimage/build_appimage.sh
index e9e9827..1456bf6 100755
--- a/appimage/build_appimage.sh
+++ b/appimage/build_appimage.sh
@@ -49,11 +49,16 @@ done
if [ -z "$VERSION" ]; then
echo "Error: --version is required"
echo "Usage: $0 --version <version>"
- echo "Example: $0 --version v1.0.0"
+ echo "Example: $0 --version 1.0.0"
exit 1
fi
-echo "Building AppImage version: $VERSION"
+# Version without 'v' prefix (for internal use)
+VERSION="${VERSION#v}"
+# Version for output filename (with 'v' prefix)
+FILE_VERSION="v${VERSION}"
+
+echo "Building AppImage version: $FILE_VERSION"
# Get the project root directory (parent of appimage folder)
PROJECT_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
@@ -145,7 +150,7 @@ export ARCH=x86_64
./squashfs-root/AppRun AppDir
GENERATED_APPIMAGE=$(ls -1 Skylight_Wallet-${VERSION}-*.AppImage 2>/dev/null | head -n1)
-DESIRED_NAME="skylight-wallet-${VERSION}-x86_64.AppImage"
+DESIRED_NAME="skylight-wallet-${FILE_VERSION}-x86_64.AppImage"
if [ -n "$GENERATED_APPIMAGE" ]; then
echo "Renaming to: $DESIRED_NAME"
diff --git a/appimage/skylight_wallet.desktop b/appimage/skylight_wallet.desktop
index c8c8442..d6c8ef8 100644
--- a/appimage/skylight_wallet.desktop
+++ b/appimage/skylight_wallet.desktop
@@ -1,7 +1,7 @@
[Desktop Entry]
Type=Application
Name=Skylight Wallet
-Comment=Monero cryptocurrency wallet
+Comment=A light Monero wallet.
Exec=skylight_wallet
Icon=skylight_wallet
Categories=Finance;Network;
diff --git a/deb/build_deb.sh b/deb/build_deb.sh
index b1392b5..55a7619 100755
--- a/deb/build_deb.sh
+++ b/deb/build_deb.sh
@@ -46,8 +46,10 @@ if [ -z "$VERSION" ]; then
exit 1
fi
-# Strip 'v' prefix if present for package version
+# Version for package metadata (without 'v' prefix)
PKG_VERSION="${VERSION#v}"
+# Version for output filename (with 'v' prefix)
+FILE_VERSION="v${PKG_VERSION}"
echo "Building .deb package version: $PKG_VERSION"
@@ -72,7 +74,7 @@ fi
echo "Creating Debian package structure..."
cd deb
rm -rf skylight-wallet_* || true
-PACKAGE_DIR="skylight-wallet_${PKG_VERSION}_amd64"
+PACKAGE_DIR="skylight-wallet_${FILE_VERSION}_amd64"
mkdir -p "$PACKAGE_DIR/DEBIAN"
mkdir -p "$PACKAGE_DIR/usr/lib/skylight-wallet"
mkdir -p "$PACKAGE_DIR/usr/bin"
@@ -89,11 +91,8 @@ Section: finance
Priority: optional
Architecture: amd64
Installed-Size: $INSTALLED_SIZE
-Maintainer: Skylight Wallet Developers
-Description: Monero cryptocurrency wallet
- A light Monero wallet with privacy-focused features.
- Skylight Wallet provides an easy-to-use interface for
- managing Monero cryptocurrency.
+Maintainer: MAGIC Grants
+Description: A light Monero wallet.
Homepage: https://github.com/skylight-wallet/skylight-wallet
EOF
diff --git a/pubspec.yaml b/pubspec.yaml
index 1a7b780..13f3e0e 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -16,7 +16,7 @@ publish_to: "none" # Remove this line if you wish to publish to pub.dev
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
# In Windows, build-name is used as the major, minor, and patch parts
# of the product and file versions while build-number is used as the build suffix.
-version: 1.0.4+9
+version: 1.0.5+10
environment:
sdk: 3.10.7
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.