← Watch feed
Include monitor name in error when failing to load a monitor
Public commit record
93/100 · Strong
What the developer wrote
Authored by Matt Corallo
Include monitor name in error when failing to load a monitor
If we fail to load a `ChannelMonitor` due to the new limits in LDK
0.2, its useful to communicate which monitor failed, which we do
here.
Requested at
https://github.com/lightningdevkit/rust-lightning/pull/4146#discussion_r2418136988
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
What changed, and why it matters
This commit only improves an error message by adding the name of a ChannelMonitor that failed to load. It is a diagnostic/logging improvement, not a security fix.
Recommended action
No security action needed; treat as routine diagnostic improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change updates an io::Error string in lightning/src/util/persist.rs to include the monitor_key when a ChannelMonitor is rejected as stale (pre-0.0.118). No logic, validation, or security behavior is changed.
Changed components
lightning/src/util/persist.rsInspect captured patch +4 / −1
diff --git a/lightning/src/util/persist.rs b/lightning/src/util/persist.rs
index 5d34603..e75f35e 100644
--- a/lightning/src/util/persist.rs
+++ b/lightning/src/util/persist.rs
@@ -955,9 +955,12 @@ where
Some(res) => Ok(res),
None => Err(io::Error::new(
io::ErrorKind::InvalidData,
- "ChannelMonitor was stale, with no updates since LDK 0.0.118. \
+ format!(
+ "ChannelMonitor {} was stale, with no updates since LDK 0.0.118. \
It cannot be read by modern versions of LDK, though also does not contain any funds left to sweep. \
You should manually delete it instead",
+ monitor_key,
+ ),
)),
}
}
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.