Re-add accidentally removed `handle_channel_update` call
What the developer wrote
Authored by Elias Rohrer
Re-add accidentally removed `handle_channel_update` call
In e620310e228e612e852ebedd555ac5dc0b9d389b, we made many, many
small changes to prepare for running `rustfmt` on `peer_handler.rs`.
Unfortunately, in the process we seem to have introduced a bug where
we'd only call `handle_channel_update` on the `RoutingMessageHandler`,
but not the `ChannelMessageHandler` anymore.
Here, we fix this and reinstate proper working of our channel updates.
What changed, and why it matters
This commit fixes a programming mistake introduced during code cleanup: a function call that tells the channel-handling part of the software about network channel updates had been accidentally deleted. Without it, the channel manager could miss important routing fee and policy updates from peers, potentially causing payment failures or stale routing decisions. The fix simply re-adds the missing call so both the routing and channel handlers receive the update.
Treat as a functional regression fix. Users running code between the regression commit and this fix should upgrade to ensure channel updates are processed correctly. No immediate exploit mitigation is indicated by the diff or commit message.
Security signals we found
Missing message-handler dispatch could cause stale channel state
Potential for payment routing based on outdated fee/policy data
Regression introduced during large refactor
No explicit security framing by vendor
Evidence from the diff
In commit e620310e228e612e852ebedd555ac5dc0b9d389b, a refactor preparing peer_handler.rs for rustfmt accidentally dropped the call to ChannelMessageHandler::handle_channel_update(their_node_id, &msg) inside the wire::Message::ChannelUpdate arm. The remaining code only called RoutingMessageHandler::handle_channel_update. The patch restores the missing call before the routing-handler call. This is a correctness/functional bug in message dispatch; the commit message frames it as a bug fix, not a security fix.
Changed components
lightning/src/ln/peer_handler.rsChannelMessageHandler trait implementationChannelUpdate message processingInspect captured patch +3 / −0
diff --git a/lightning/src/ln/peer_handler.rs b/lightning/src/ln/peer_handler.rs
index 98e54ee..f237403 100644
--- a/lightning/src/ln/peer_handler.rs
+++ b/lightning/src/ln/peer_handler.rs
@@ -2593,6 +2593,9 @@ where
self.update_gossip_backlogged();
},
wire::Message::ChannelUpdate(msg) => {
+ let chan_handler = &self.message_handler.chan_handler;
+ chan_handler.handle_channel_update(their_node_id, &msg);
+
let route_handler = &self.message_handler.route_handler;
if route_handler
.handle_channel_update(Some(their_node_id), &msg)
Why this scored 59/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.