Remove stray `println` from LSPS2 tests
What the developer wrote
Authored by Elias Rohrer
Remove stray `println` from LSPS2 tests
What changed, and why it matters
This commit removes a leftover debug print statement from a test file. It has no security relevance: the println only ran during automated tests, printed non-sensitive JSON test data, and could not be exploited by users or attackers.
No action required. The change is a routine code-quality cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes a single println! macro call inside a Rust unit test in lightning-liquidity/src/lsps2/msgs.rs. The removed line printed a JSON serialization of opening_fee_params during test execution. It was not compiled into production code, did not log to persistent storage, and exposed only hard-coded test values already present in the same file.
Changed components
lightning-liquidity/src/lsps2/msgs.rs unit testsInspect captured patch +0 / −1
diff --git a/lightning-liquidity/src/lsps2/msgs.rs b/lightning-liquidity/src/lsps2/msgs.rs
index ff8f53d..699e5a3 100644
--- a/lightning-liquidity/src/lsps2/msgs.rs
+++ b/lightning-liquidity/src/lsps2/msgs.rs
@@ -446,7 +446,6 @@ mod tests {
);
let opening_fee_params = raw.into_opening_fee_params(&promise_secret, &client_node_id);
- println!("SERIALIZATION: {}", serde_json::json!(opening_fee_params).to_string());
let json_str = r#"{"max_client_to_self_delay":128,"max_payment_size_msat":"100000000","min_fee_msat":"100","min_lifetime":144,"min_payment_size_msat":"1","promise":"75eb57db4c37dc092a37f1d2e0026c5ff36a7834a717ea97c41d91a8d5b50ce8","proportional":21,"valid_until":"2023-05-20T08:30:45Z"}"#;
assert_eq!(json_str, serde_json::json!(opening_fee_params).to_string());
assert_eq!(opening_fee_params, serde_json::from_str(json_str).unwrap());
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.