Move shellcheck step from build job to linting job
What the developer wrote
Authored by Joost Jager
Move shellcheck step from build job to linting job
Shellcheck is a static analysis tool for shell scripts and belongs with
the other linting checks rather than in the build matrix. This also
prepares for splitting the build job into parallel sub-jobs, where
running shellcheck in each sub-job would be redundant.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
What changed, and why it matters
This commit simply reorganizes a GitHub Actions workflow file. It moves a shell script linting check (shellcheck) from the build job to a dedicated linting job. There is no change to the actual Rust Lightning code, no security fix, and no change in what is being checked—only where in the CI pipeline the check runs.
No security action needed. This is a routine CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/build.yml. It removes the shellcheck step from the build job (which previously only ran on the self-hosted platform) and adds the identical shellcheck step to the linting job. The commands, flags, and files checked are unchanged. The stated rationale is organizational: shellcheck is a static analysis/linting tool and belongs with other linting checks, plus this avoids redundant execution if the build job is later split into parallel sub-jobs.
Changed components
.github/workflows/build.ymlInspect captured patch +4 / −5
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0fbc9ed..abc580b 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -60,11 +60,6 @@ jobs:
if: "matrix.platform == 'self-hosted'"
run: |
rustup target add thumbv7m-none-eabi
- - name: shellcheck the CI and `contrib` scripts
- if: "matrix.platform == 'self-hosted'"
- run: |
- shellcheck ci/*.sh -aP ci
- shellcheck contrib/*.sh -aP contrib
- name: Set RUSTFLAGS to deny warnings
if: "matrix.toolchain == '1.75.0'"
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
@@ -305,6 +300,10 @@ jobs:
- name: Install clippy
run: |
rustup component add clippy
+ - name: shellcheck the CI and `contrib` scripts
+ run: |
+ shellcheck ci/*.sh -aP ci
+ shellcheck contrib/*.sh -aP contrib
- name: Run default clippy linting
run: |
./ci/check-lint.sh
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.