Reduce visibility of ConstructedTransaction methods
What the developer wrote
Authored by Jeffrey Czyz
Reduce visibility of ConstructedTransaction methods
What changed, and why it matters
This commit simply changes two methods of an internal Rust struct from public (`pub`) to private (`fn`). It is a routine code-cleanup change that reduces how much of the code is exposed outside the module. There is no bug fix, no change in behavior, and no security issue visible in the diff.
No action required. Treat as normal refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch lowers visibility of ConstructedTransaction::input_metadata and ConstructedTransaction::holder_is_initiator from pub to module-private. This is a pure API-hardening/refactoring change within lightning/src/ln/interactivetxs.rs. No logic, validation, or memory-safety behavior is altered.
Changed components
lightning/src/ln/interactivetxs.rsInspect captured patch +2 / −2
diff --git a/lightning/src/ln/interactivetxs.rs b/lightning/src/ln/interactivetxs.rs
index 32f4a46..3c683fc 100644
--- a/lightning/src/ln/interactivetxs.rs
+++ b/lightning/src/ln/interactivetxs.rs
@@ -310,7 +310,7 @@ impl ConstructedTransaction {
&self.tx
}
- pub fn input_metadata(&self) -> impl Iterator<Item = &TxInMetadata> {
+ fn input_metadata(&self) -> impl Iterator<Item = &TxInMetadata> {
self.input_metadata.iter()
}
@@ -421,7 +421,7 @@ impl ConstructedTransaction {
.for_each(|(input, witness)| input.witness = witness);
}
- pub fn holder_is_initiator(&self) -> bool {
+ fn holder_is_initiator(&self) -> bool {
self.holder_is_initiator
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.