Drop `cfg(async_payments)` from tests
What the developer wrote
Authored by Elias Rohrer
Drop `cfg(async_payments)` from tests
We previously dropped `cfg(async_payments)` but didn't drop the actual
`cargo test` call from our CI. Here we do that.
What changed, and why it matters
This commit simply removes one test command from the project's continuous integration script. It is a cleanup change with no security relevance: it stops running tests under an 'async_payments' configuration flag that had already been removed from the code. There is no vulnerability, no bug fix, and no user-facing behavior change.
No security action needed. This is a routine CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes two lines from ci/ci-tests.sh that ran RUSTFLAGS="--cfg=async_payments" cargo test -p lightning and an associated conditional cargo clean. The commit message explains this is a follow-up to a prior removal of cfg(async_payments) from the codebase, cleaning up the now-redundant CI invocation. No source code, cryptographic logic, network handling, or test assertions are modified.
Changed components
ci/ci-tests.shInspect captured patch +0 / −2
diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index c3637ab..41faed6 100755
--- a/ci/ci-tests.sh
+++ b/ci/ci-tests.sh
@@ -141,8 +141,6 @@ fi
echo -e "\n\nTest cfg-flag builds"
RUSTFLAGS="--cfg=taproot" cargo test --verbose --color always -p lightning
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=async_payments" cargo test --verbose --color always -p lightning
-[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
RUSTFLAGS="--cfg=simple_close" cargo test --verbose --color always -p lightning
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
RUSTFLAGS="--cfg=lsps1_service" cargo test --verbose --color always -p lightning-liquidity
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.