AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 48 Bitcoin

Set dont_forward on private channel updates and add tests

Public commit record

What the developer wrote

Authored by Thrishalmadasu

60/100 · Adequate
Set dont_forward on private channel updates and add tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a protocol-compliance issue in LDK's Lightning channel update messages. Private (unannounced) channels now correctly set the 'dont_forward' flag on their channel_update messages, telling other nodes not to relay them across the network. Public channels continue not to set this flag. The change also adds a warning log when a node receives a channel_update for an unknown channel that has dont_forward set, which can help diagnose configuration mistakes. This is a correctness and privacy improvement rather than a critical vulnerability.

Recommended action

Review and merge. The change is low-risk and improves protocol correctness. Operators running nodes with private channels should ensure they are on a version containing this commit to avoid unintended gossip propagation of private channel parameters.

Security signals we found

01

Protocol compliance: BOLT 7 message_flags bit 1 (dont_forward) now honored for private channels

02

Privacy improvement: private channel updates are explicitly marked non-relayable

03

Diagnostic logging added for unknown-channel updates with dont_forward set

04

No memory safety, cryptographic, or authorization changes observed

Risk score

Why this scored 48/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.