Remove stale comment in transaction decoding
What the developer wrote
Authored by Tobin C. Harding
Remove stale comment in transaction decoding
This comment is stale now that we remove the old transition stuff.
What changed, and why it matters
This commit only removes two lines of stale explanatory comment from transaction decoding code. No code behavior changes, no security relevance.
No action needed; this is a non-functional documentation cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes a comment in primitives/src/transaction.rs inside the TransactionDecoder state machine. The comment explained why the inputs vector was obtained in a particular match arm rather than in the pattern match. No executable code, logic, or data handling was modified.
Changed components
primitives/src/transaction.rsInspect captured patch +0 / −2
diff --git a/primitives/src/transaction.rs b/primitives/src/transaction.rs
index 3d8a1bdb..b3456074 100644
--- a/primitives/src/transaction.rs
+++ b/primitives/src/transaction.rs
@@ -464,8 +464,6 @@ impl Decoder for TransactionDecoder {
self.state = State::Inputs(version, Attempt::Second, VecDecoder::<TxIn>::new());
}
State::Outputs(version, inputs, is_segwit, decoder) => {
- // We get the inputs vector here instead of in the pattern match because I
- // couldn't find another way to get it out of behind the mutable reference.
let outputs = decoder.end()?;
if is_segwit == IsSegwit::Yes {
self.state = State::Witnesses(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.