← Watch feed
Upgrade maintainer tools and add quiet mode
Public commit record
80/100 · Strong
What the developer wrote
Authored by Nick Johnson
Upgrade maintainer tools and add quiet mode
The lint in CI will now fail on duplicate deps. Moved the whitelist
to the correct spot so that the current in-progress crates don't fail
the check.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
What changed, and why it matters
This commit is a routine maintenance update to the project's build and lint scripts. It upgrades internal maintainer tools, adds a 'quiet' log mode for CI runs, and adjusts the list of allowed duplicate dependencies. There are no changes to the actual Bitcoin library code that users or applications interact with, and nothing in the commit suggests a security problem or fix.
Recommended action
No security action required. Review as normal build-hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff only touches CI/build scaffolding: extra_lints.sh scripts across workspace crates lose their shebang and set -ex because they are sourced rather than executed; the dependency duplicate whitelist is moved from bitcoin/contrib/whitelist_deps.sh to contrib/whitelist_deps.sh and updated; the justfile sets MAINTAINER_TOOLS_LOG_LEVEL=quiet; and maintainer-tools-version is bumped to a new commit. No Rust source code, no cryptographic code, no API changes, and no runtime behavior changes are present.
Changed components
CI/build scripts (contrib/extra_lints.sh, contrib/whitelist_deps.sh, justfile, maintainer-tools-version)Inspect captured patch +34 / −42
diff --git a/addresses/contrib/extra_lints.sh b/addresses/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/addresses/contrib/extra_lints.sh
+++ b/addresses/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/base58/contrib/extra_lints.sh b/base58/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/base58/contrib/extra_lints.sh
+++ b/base58/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/bitcoin/contrib/extra_lints.sh b/bitcoin/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/bitcoin/contrib/extra_lints.sh
+++ b/bitcoin/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/bitcoin/contrib/whitelist_deps.sh b/bitcoin/contrib/whitelist_deps.sh
deleted file mode 100644
index 42cc286e..00000000
--- a/bitcoin/contrib/whitelist_deps.sh
+++ /dev/null
@@ -1,7 +0,0 @@
-# No shebang, this file should not be executed.
-# shellcheck disable=SC2148
-#
-# disable verify unused vars, despite the fact that they are used when sourced
-# shellcheck disable=SC2034
-
-DUPLICATE_DEPS=("hashes")
diff --git a/chacha20_poly1305/contrib/extra_lints.sh b/chacha20_poly1305/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/chacha20_poly1305/contrib/extra_lints.sh
+++ b/chacha20_poly1305/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/consensus_encoding/contrib/extra_lints.sh b/consensus_encoding/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/consensus_encoding/contrib/extra_lints.sh
+++ b/consensus_encoding/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/contrib/whitelist_deps.sh b/contrib/whitelist_deps.sh
new file mode 100644
index 00000000..cb4a22b1
--- /dev/null
+++ b/contrib/whitelist_deps.sh
@@ -0,0 +1,10 @@
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
+#
+# disable verify unused vars, despite the fact that they are used when sourced
+# shellcheck disable=SC2034
+
+# - hashes because of secp v0.30
+# - io because of hashes
+# - hex because 1.0 only has decoding
+DUPLICATE_DEPS=("bitcoin_hashes" "hex-conservative" "bitcoin-io")
diff --git a/hashes/contrib/extra_lints.sh b/hashes/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/hashes/contrib/extra_lints.sh
+++ b/hashes/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/internals/contrib/extra_lints.sh b/internals/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/internals/contrib/extra_lints.sh
+++ b/internals/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/io/contrib/extra_lints.sh b/io/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/io/contrib/extra_lints.sh
+++ b/io/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/justfile b/justfile
index 55bbe19a..299ff3a2 100644
--- a/justfile
+++ b/justfile
@@ -13,7 +13,7 @@ _default:
@ci task toolchain="stable" lock="recent":
{{justfile_directory()}}/contrib/ensure-maintainer-tools.sh
cp -f {{justfile_directory()}}/Cargo-{{lock}}.lock {{justfile_directory()}}/Cargo.lock
- rustup run {{toolchain}} {{justfile_directory()}}/.maintainer-tools/ci/run_task.sh {{task}}
+ MAINTAINER_TOOLS_LOG_LEVEL=quiet rustup run {{toolchain}} {{justfile_directory()}}/.maintainer-tools/ci/run_task.sh {{task}}
# Test workspace with stable toolchain.
[group('ci')]
diff --git a/maintainer-tools-version b/maintainer-tools-version
index 866abbff..f9a7d00f 100644
--- a/maintainer-tools-version
+++ b/maintainer-tools-version
@@ -1 +1 @@
-22eff1e5c114949d4b88a24735da38b37e7984fb
+e7ad5b2aa5f742093d8e07d4a2a7d415254cf6f4
diff --git a/p2p/contrib/extra_lints.sh b/p2p/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/p2p/contrib/extra_lints.sh
+++ b/p2p/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/primitives/contrib/extra_lints.sh b/primitives/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/primitives/contrib/extra_lints.sh
+++ b/primitives/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/units/contrib/extra_lints.sh b/units/contrib/extra_lints.sh
index 9c20f319..5e7f0c94 100755
--- a/units/contrib/extra_lints.sh
+++ b/units/contrib/extra_lints.sh
@@ -1,5 +1,4 @@
-#!/usr/bin/env bash
-
-set -ex
+# No shebang, this file should not be executed.
+# shellcheck disable=SC2148
cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.