What the developer wrote
Authored by Abeeujah
Use TxInEncoder for TxIn encoding
TxIn has a TxInEncoder newtype for consensus encoding TxIn
objects, but the Encode implementation currently uses a bare
Encoder3.
This fails to properly encapsulate the inner state of the
TxIn type and its encoding behavior. Switch the implementation
to use TxInEncoder.
What changed, and why it matters
This is a small internal code cleanup in the rust-bitcoin library. It changes how transaction input (TxIn) objects are prepared for serialization so they use a dedicated wrapper type (TxInEncoder) instead of a generic three-field encoder. The commit message frames this as better encapsulation, but the diff itself only shows a refactor with no change to the actual serialized bytes or to public behavior. There is no direct evidence of a security vulnerability being fixed.
Treat as a routine refactor. Reviewers may optionally verify that TxInEncoder delegates identically to the previous Encoder3 composition to ensure no consensus serialization change was introduced, but no security response is indicated by the available evidence.
Security signals we found
Commit message uses language ('fails to properly encapsulate') that can sound security-adjacent, but describes a design/encapsulation issue rather than a concrete vulnerability
No change to serialized wire format, field order, or public API visible in the diff
No references to CVEs, advisories, security reports, or researcher attribution in commit or supplied materials
Evidence from the diff
The patch modifies primitives/src/transaction.rs so that the Encode implementation for TxIn returns TxInEncoder<’e> rather than the bare Encoder3
Changed components
primitives/src/transaction.rsTxIn consensus encoding (Encode trait implementation)TxInEncoder newtypeInspect captured patch +3 / −3
diff --git a/primitives/src/transaction.rs b/primitives/src/transaction.rs
index da9a66a3..0054dd6f 100644
--- a/primitives/src/transaction.rs
+++ b/primitives/src/transaction.rs
@@ -763,16 +763,16 @@ encoding::encoder_newtype_exact! {
#[cfg(feature = "alloc")]
impl encoding::Encode for TxIn {
type Encoder<'e>
- = Encoder3<OutPointEncoder<'e>, ScriptEncoder<'e>, SequenceEncoder<'e>>
+ = TxInEncoder<'e>
where
Self: 'e;
fn encoder(&self) -> Self::Encoder<'_> {
- Encoder3::new(
+ TxInEncoder::new(Encoder3::new(
self.previous_output.encoder(),
self.script_sig.encoder(),
self.sequence.encoder(),
- )
+ ))
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.