Informational 15 Bitcoin Committed Mar 26, 2026 · 19:48 UTC

Create a bunch of test case consts in transaction

d4165f1a View source ↗

Public commit record

What the developer wrote

Authored by Jamil Lambert, PhD

78/100 · Adequate

Create a bunch of test case consts in transaction

Make some of the tests easier to read and avoid duplication by creating
some byte array constants for values that are used multiple times.
Use these constants in the tests.

✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification

The short version

What changed, and why it matters

This commit is a simple cleanup of internal unit tests. It replaces repeated hard-coded byte lists with named constants inside test code. There is no change to the actual library behavior, no bug fix, and no security relevance.

Recommended action

No action required; this is a non-functional test refactor.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The patch refactors test-only code in primitives/src/transaction.rs. It introduces const byte arrays (e.g., TC_TXID_BYTES, TC_SCRIPT_BYTES) and uses them in place of inline byte literals within assertions and helper functions. The values are identical to those previously used; only duplication is reduced. No production logic is modified.

Changed components

primitives/src/transaction.rs (test module only)

Inspect captured patch +52 / −71

diff --git a/primitives/src/transaction.rs b/primitives/src/transaction.rs
index 4072635b..80ff35a3 100644
--- a/primitives/src/transaction.rs
+++ b/primitives/src/transaction.rs
@@ -1657,6 +1657,22 @@ mod tests {
     #[cfg(all(feature = "alloc", feature = "hex"))]
     use crate::absolute::LockTime;
 
+    const TC_TXID_BYTES: [u8; 32] = [
+        32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10,
+        9, 8, 7, 6, 5, 4, 3, 2, 1,
+    ];
+    const TC_VOUT_BYTES: [u8; 4] = [1, 0, 0, 0];
+    const TC_SCRIPT_BYTES: [u8; 3] = [1, 2, 3];
+    #[cfg(feature = "hex")]
+    const TC_SEQ_MAX_BYTES: [u8; 4] = [0xff, 0xff, 0xff, 0xff];
+    #[cfg(feature = "hex")]
+    const TC_LOCK_TIME_ZERO_BYTES: [u8; 4] = [0, 0, 0, 0];
+    const TC_ONE_SAT_BYTES: [u8; 8] = [1, 0, 0, 0, 0, 0, 0, 0];
+    #[cfg(feature = "hex")]
+    const TC_SEGWIT_MARKER_AND_FLAG: [u8; 2] = [0, 1];
+    #[cfg(feature = "hex")]
+    const TC_WITNESS_ELEM_LEN_AND_DATA: [u8; 4] = [3, 1, 2, 3];
+
     #[test]
     #[cfg(feature = "alloc")]
     #[cfg(feature = "hex")]
@@ -1961,8 +1977,7 @@ mod tests {
 
     #[cfg(any(feature = "hex", feature = "serde"))]
     fn segwit_tx_in() -> TxIn {
-        let bytes = [1u8, 2, 3];
-        let data = [&bytes[..]];
+        let data = [&TC_SCRIPT_BYTES[..]];
         let witness = Witness::from_iter(data);
 
         TxIn {
@@ -1975,15 +1990,11 @@ mod tests {
 
     #[cfg(feature = "alloc")]
     fn tc_script_pubkey() -> ScriptPubKeyBuf {
-        let script_bytes = vec![1, 2, 3];
-        ScriptPubKeyBuf::from_bytes(script_bytes)
+        ScriptPubKeyBuf::from_bytes(TC_SCRIPT_BYTES.to_vec())
     }
 
     #[cfg(any(feature = "hex", feature = "serde"))]
-    fn tc_script_sig() -> ScriptSigBuf {
-        let script_bytes = vec![1, 2, 3];
-        ScriptSigBuf::from_bytes(script_bytes)
-    }
+    fn tc_script_sig() -> ScriptSigBuf { ScriptSigBuf::from_bytes(TC_SCRIPT_BYTES.to_vec()) }
 
     #[test]
     #[cfg(feature = "alloc")]
@@ -1993,17 +2004,11 @@ mod tests {
         let mut encoder = out_point.encoder();
 
         // The txid
-        assert_eq!(
-            encoder.current_chunk(),
-            &[
-                32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12,
-                11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1
-            ][..]
-        );
+        assert_eq!(encoder.current_chunk(), &TC_TXID_BYTES[..]);
         assert!(encoder.advance());
 
         // The vout
-        assert_eq!(encoder.current_chunk(), &[1u8, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_VOUT_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted
@@ -2017,7 +2022,7 @@ mod tests {
         let mut encoder = out.encoder();
 
         // The amount.
-        assert_eq!(encoder.current_chunk(), &[1, 0, 0, 0, 0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_ONE_SAT_BYTES[..]);
         assert!(encoder.advance());
 
         // The script pubkey length prefix.
@@ -2025,7 +2030,7 @@ mod tests {
         assert!(encoder.advance());
 
         // The script pubkey data.
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted
@@ -2040,25 +2045,19 @@ mod tests {
         let mut encoder = txin.encoder();
 
         // The outpoint (same as tested above).
-        assert_eq!(
-            encoder.current_chunk(),
-            &[
-                32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12,
-                11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1
-            ][..]
-        );
+        assert_eq!(encoder.current_chunk(), &TC_TXID_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_VOUT_BYTES[..]);
         assert!(encoder.advance());
 
         // The script sig
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
 
         // The sequence
-        assert_eq!(encoder.current_chunk(), &[0xffu8, 0xff, 0xff, 0xff][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEQ_MAX_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted
@@ -2082,47 +2081,41 @@ mod tests {
         assert!(encoder.advance());
 
         // The segwit marker and flag
-        assert_eq!(encoder.current_chunk(), &[0u8, 1][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEGWIT_MARKER_AND_FLAG[..]);
         assert!(encoder.advance());
 
         // The input (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(
-            encoder.current_chunk(),
-            &[
-                32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12,
-                11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1
-            ][..]
-        );
+        assert_eq!(encoder.current_chunk(), &TC_TXID_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_VOUT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[0xffu8, 0xff, 0xff, 0xff][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEQ_MAX_BYTES[..]);
         assert!(encoder.advance());
 
         // The output (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1, 0, 0, 0, 0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_ONE_SAT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
 
         // The witness
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[3u8, 1, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_WITNESS_ELEM_LEN_AND_DATA[..]);
         assert!(encoder.advance());
 
         // The lock time.
-        assert_eq!(encoder.current_chunk(), &[0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_LOCK_TIME_ZERO_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted
@@ -2155,38 +2148,32 @@ mod tests {
         // The input (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(
-            encoder.current_chunk(),
-            &[
-                32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12,
-                11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1
-            ][..]
-        );
+        assert_eq!(encoder.current_chunk(), &TC_TXID_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_VOUT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[0xffu8, 0xff, 0xff, 0xff][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEQ_MAX_BYTES[..]);
         assert!(encoder.advance());
 
         // The output (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1, 0, 0, 0, 0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_ONE_SAT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
 
         // Advance past the optional witnesses encoder.
         assert!(encoder.advance());
 
         // The lock time.
-        assert_eq!(encoder.current_chunk(), &[0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_LOCK_TIME_ZERO_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted
@@ -2266,43 +2253,37 @@ mod tests {
         assert_eq!(encoder.current_chunk(), &[2u8, 0, 0, 0][..]);
         assert!(encoder.advance());
         // The segwit marker and flag
-        assert_eq!(encoder.current_chunk(), &[0u8, 1][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEGWIT_MARKER_AND_FLAG[..]);
         assert!(encoder.advance());
         // The input (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(
-            encoder.current_chunk(),
-            &[
-                32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12,
-                11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1
-            ][..]
-        );
+        assert_eq!(encoder.current_chunk(), &TC_TXID_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_VOUT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[0xffu8, 0xff, 0xff, 0xff][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SEQ_MAX_BYTES[..]);
         assert!(encoder.advance());
         // The output (same as tested above) but with vec length prefix.
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1, 0, 0, 0, 0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_ONE_SAT_BYTES[..]);
         assert!(encoder.advance());
         assert_eq!(encoder.current_chunk(), &[3u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[1u8, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_SCRIPT_BYTES[..]);
         assert!(encoder.advance());
         // The witness
         assert_eq!(encoder.current_chunk(), &[1u8][..]);
         assert!(encoder.advance());
-        assert_eq!(encoder.current_chunk(), &[3u8, 1, 2, 3][..]);
+        assert_eq!(encoder.current_chunk(), &TC_WITNESS_ELEM_LEN_AND_DATA[..]);
         assert!(encoder.advance());
         // The lock time.
-        assert_eq!(encoder.current_chunk(), &[0, 0, 0, 0][..]);
+        assert_eq!(encoder.current_chunk(), &TC_LOCK_TIME_ZERO_BYTES[..]);
         assert!(!encoder.advance());
 
         // Exhausted

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Merge rust-bitcoin/rust-bitcoin#6670: ci: fix labeller permissions

Merge rust-bitcoin/rust-bitcoin#6657: Release tracking PR: `base58ck 0.5.0`

Merge rust-bitcoin/rust-bitcoin#6440: base58: Introduce `decode_check_to_array` for alloc-less decoding