What the developer wrote
Authored by Abeeujah
Use TxOutEncoder for TxOut encoding
TxOut has a TxOutEncoder newtype for consensus encoding TxOut
objects, but the Encode implementation currently uses a bare
Encoder3.
This fails to properly encapsulate the inner state of the
TxOut type and its encoding behavior. Switch the implementation
to use TxOutEncoder.
What changed, and why it matters
This is a small internal code cleanup in the rust-bitcoin library. It changes how transaction output (TxOut) objects are prepared for serialization so they use a dedicated wrapper type (TxOutEncoder) instead of directly combining two lower-level encoders. The commit message frames this as improving encapsulation, but the diff itself does not show any actual security bug, exploit path, or behavior change in the serialized output. It is best treated as a defensive maintenance patch.
Treat as routine code-quality/maintenance change. Reviewers may verify that TxOutEncoder::new preserves the same byte-for-byte consensus encoding as the previous direct Encoder2 construction, and that no downstream code depends on the previous concrete Encoder type. No urgent security action is indicated by the diff alone.
Security signals we found
Refactor to use dedicated encoder newtype (TxOutEncoder) for TxOut consensus encoding
Commit message uses security-adjacent language ('properly encapsulate inner state', 'encoding behavior')
No diff evidence of memory safety bug, consensus mismatch, or injection point
Evidence from the diff
The patch modifies the Encode implementation for TxOut in primitives/src/transaction.rs. Previously the associated Encoder type was a raw Encoder2
Changed components
primitives/src/transaction.rsTxOut consensus encoding implementationTxOutEncoder newtypeInspect captured patch +2 / −2
diff --git a/primitives/src/transaction.rs b/primitives/src/transaction.rs
index 0054dd6f..595fbdfd 100644
--- a/primitives/src/transaction.rs
+++ b/primitives/src/transaction.rs
@@ -890,12 +890,12 @@ encoding::encoder_newtype_exact! {
#[cfg(feature = "alloc")]
impl encoding::Encode for TxOut {
type Encoder<'e>
- = Encoder2<AmountEncoder<'e>, ScriptEncoder<'e>>
+ = TxOutEncoder<'e>
where
Self: 'e;
fn encoder(&self) -> Self::Encoder<'_> {
- Encoder2::new(self.amount.encoder(), self.script_pubkey.encoder())
+ TxOutEncoder::new(Encoder2::new(self.amount.encoder(), self.script_pubkey.encoder()))
}
}
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.