What the developer wrote
Authored by Tobin C. Harding
Remove stale comment
This function is no longer duplicated, I don't remember when or why it
got removed but it no longer exists in `bitcoin`.
What changed, and why it matters
This commit simply removes a one-line comment that had become outdated. The comment claimed a helper function was duplicated in another file, but that duplicate no longer exists. No actual code behavior was changed, so there is no security impact.
No action required; this is a non-functional documentation cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes a stale documentation comment in primitives/src/witness.rs above the decode_cursor helper. The function body, signatures, and all call sites remain unchanged. There are no logic, API, or dependency modifications.
Changed components
primitives/src/witness.rsInspect captured patch +0 / −1
diff --git a/primitives/src/witness.rs b/primitives/src/witness.rs
index 1210cf58..a4d3607a 100644
--- a/primitives/src/witness.rs
+++ b/primitives/src/witness.rs
@@ -266,7 +266,6 @@ fn encode_cursor(bytes: &mut [u8], start_of_indices: usize, index: usize, value:
.copy_from_slice(&u32::to_ne_bytes(value.try_into().expect("larger than u32")));
}
-// This is duplicated in `bitcoin::blockdata::witness`, if you change them do so over there also.
#[inline]
fn decode_cursor(bytes: &[u8], start_of_indices: usize, index: usize) -> Option<usize> {
let start = start_of_indices + index * 4;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.