What the developer wrote
Authored by jrakibi
hashes: Add test for `hash_64_many`
test block counts 0 through 32
this allows our test to go through all SIMD distpatch paths we have:
- 1 block: software path
- 2 blocks: 2-way
- 3 blocks: 2-way + last block software
- 4 blocks: 2-way for now, (4-way once we add it)
- 8 blocks: 2-way for now (8-way once we add it)
- ... and so on up to 32
What changed, and why it matters
This commit only adds a new automated test for an existing function called hash_64_many. It does not change any production code, fix a bug, or alter behavior. There is no security issue here.
No action needed; this is a benign test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a unit test in hashes/src/sha256d/mod.rs that exercises sha256d::Hash::hash_64_many with input block counts from 0 to 32, comparing outputs against the single-block sha256d::hash reference. No implementation code is modified.
Changed components
hashes/src/sha256d/mod.rsInspect captured patch +24 / −0
diff --git a/hashes/src/sha256d/mod.rs b/hashes/src/sha256d/mod.rs
index 0c49d015..64b82efc 100644
--- a/hashes/src/sha256d/mod.rs
+++ b/hashes/src/sha256d/mod.rs
@@ -141,4 +141,28 @@ mod tests {
&[Token::Str("6cfb35868c4465b7c289d7d5641563aa973db6a929655282a7bf95c8257f53ef")],
);
}
+
+ #[test]
+ #[cfg(feature = "alloc")]
+ fn hash_64_many() {
+ for count in 0..=32 {
+ let inputs: alloc::vec::Vec<[u8; 64]> = (0..count)
+ .map(|i: usize| {
+ let mut block = [0u8; 64];
+ for (j, byte) in block.iter_mut().enumerate() {
+ *byte = (i * 64 + j) as u8;
+ }
+ block
+ })
+ .collect();
+
+ let expected: alloc::vec::Vec<[u8; 32]> =
+ inputs.iter().map(|inp| sha256d::hash(inp).to_byte_array()).collect();
+
+ let mut outputs = alloc::vec![[0u8; 32]; count];
+ sha256d::Hash::hash_64_many(&mut outputs, &inputs);
+
+ assert_eq!(outputs, expected);
+ }
+ }
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.