What the developer wrote
Authored by Conger Rassen
hashes: simplify trait bounds
What changed, and why it matters
This is a tiny code cleanup change in the rust-bitcoin hashes library. It replaces a more verbose way of referring to a constant (<H as HashEngine>::BLOCK_SIZE) with a simpler equivalent (H::BLOCK_SIZE). The behavior of the program is unchanged, and there is no security relevance.
No action needed. This is a non-functional refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit simplifies a trait-associated constant access in hashes/src/lib.rs. The fully-qualified syntax
Changed components
hashes/src/lib.rsInspect captured patch +1 / −1
diff --git a/hashes/src/lib.rs b/hashes/src/lib.rs
index 91331d22..7e027b42 100644
--- a/hashes/src/lib.rs
+++ b/hashes/src/lib.rs
@@ -255,7 +255,7 @@ mod sealed {
}
fn incomplete_block_len<H: HashEngine>(eng: &H) -> usize {
- let block_size = <H as HashEngine>::BLOCK_SIZE as u64; // Cast usize to u64 is ok.
+ let block_size = H::BLOCK_SIZE as u64; // Cast usize to u64 is ok.
// After modulo operation we know cast u64 to usize as ok.
(eng.n_bytes_hashed() % block_size) as usize
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.