What the developer wrote
Authored by Tobin C. Harding
hashes: Remove unnecessary clone
No need to clone. The `State` struct is `Copy` because all fields are
`Copy` (I _think_).
We could remove the local var all together but what ever.
What changed, and why it matters
This is a tiny code cleanup in a Rust hashing library. It removes an unnecessary `.clone()` call because the underlying data type can be copied automatically. There is no security issue here.
No action needed. This is a benign cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes one line in hashes/src/siphash24/mod.rs, replacing let state = e.state.clone(); with let state = e.state;. The State struct is Copy, so explicit cloning is redundant. This is a non-functional refactor with no behavioral or security change.
Changed components
hashes/src/siphash24/mod.rsInspect captured patch +1 / −1
diff --git a/hashes/src/siphash24/mod.rs b/hashes/src/siphash24/mod.rs
index 97eca32f..4ad9bdfd 100644
--- a/hashes/src/siphash24/mod.rs
+++ b/hashes/src/siphash24/mod.rs
@@ -63,7 +63,7 @@ impl Hash {
#[cfg(hashes_fuzz)]
pub fn from_engine(e: HashEngine) -> Self {
- let state = e.state.clone();
+ let state = e.state;
Hash::from_u64(state.v0 ^ state.v1 ^ state.v2 ^ state.v3)
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.