← Watch feed
Increase Criterion benchmark time for block
Public commit record
60/100 · Adequate
What the developer wrote
Authored by Jamil Lambert, PhD
Increase Criterion benchmark time for block
The benchmark for block does not complete 100 samples in the default 5
seconds.
Increase the time to 10 seconds.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
What changed, and why it matters
This commit only changes a benchmark test so it runs longer. It does not touch any production code, so it has no security impact on users of the library.
Recommended action
No security action needed; this is a benign test-configuration change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies benches/bitcoin/block.rs, adding a 10-second Criterion measurement time and 3-second warm-up to a block-parsing benchmark. No library, consensus, or network code is changed.
Changed components
benches/bitcoin/block.rsInspect captured patch +2 / −0
diff --git a/benches/bitcoin/block.rs b/benches/bitcoin/block.rs
index 559f945c..6ac155c7 100644
--- a/benches/bitcoin/block.rs
+++ b/benches/bitcoin/block.rs
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: CC0-1.0
+use std::time::Duration;
use std::hint::black_box;
use bitcoin::blockdata::block::Block;
@@ -14,6 +15,7 @@ fn bench_block(c: &mut Criterion) {
let mut g = c.benchmark_group("block");
g.throughput(Throughput::Bytes(raw_block.len() as u64));
+ g.measurement_time(Duration::from_secs(10)).warm_up_time(Duration::from_secs(3));
g.bench_function(BenchmarkId::new("stream_reader", "big"), |b| {
let big_block = black_box(raw_block.as_ref());
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.