What the developer wrote
Authored by Jakub Gladysz
Rename serde tests in units
What changed, and why it matters
This commit only renames six test functions in a Rust test file to make their names more descriptive (adding 'amount' to clarify they test amount serialization). It changes no actual code behavior, no logic, and no public API. There is no security relevance.
No action needed; this is a non-functional test-only rename.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff renames test functions in units/tests/serde.rs: serde_as_sat -> serde_amount_as_sat, serde_as_btc -> serde_amount_as_btc, serde_as_str -> serde_amount_as_str, serde_as_btc_opt -> serde_amount_as_btc_opt, serde_as_sat_opt -> serde_amount_as_sat_opt, serde_as_str_opt -> serde_amount_as_str_opt. No implementation code, no serde modules, no serialization/deserialization behavior is modified.
Changed components
units/tests/serde.rsInspect captured patch +6 / −6
diff --git a/units/tests/serde.rs b/units/tests/serde.rs
index ef16094c..753ff4b5 100644
--- a/units/tests/serde.rs
+++ b/units/tests/serde.rs
@@ -97,7 +97,7 @@ fn ssat(ssat: i64) -> SignedAmount { SignedAmount::from_sat(ssat).unwrap() }
#[test]
#[cfg(feature = "serde")]
-fn serde_as_sat() {
+fn serde_amount_as_sat() {
#[derive(Serialize, Deserialize, PartialEq, Debug)]
struct T {
#[serde(with = "crate::amount::serde::as_sat")]
@@ -123,7 +123,7 @@ fn serde_as_sat() {
#[cfg(feature = "serde")]
#[cfg(feature = "alloc")]
#[allow(clippy::inconsistent_digit_grouping)] // Group to show 100,000,000 sats per bitcoin.
-fn serde_as_btc() {
+fn serde_amount_as_btc() {
use serde_json;
#[derive(Serialize, Deserialize, PartialEq, Debug)]
@@ -148,7 +148,7 @@ fn serde_as_btc() {
#[test]
#[cfg(feature = "serde")]
#[cfg(feature = "alloc")]
-fn serde_as_str() {
+fn serde_amount_as_str() {
#[derive(Serialize, Deserialize, PartialEq, Debug)]
struct T {
#[serde(with = "crate::amount::serde::as_str")]
@@ -174,7 +174,7 @@ fn serde_as_str() {
#[cfg(feature = "serde")]
#[cfg(feature = "alloc")]
#[allow(clippy::inconsistent_digit_grouping)] // Group to show 100,000,000 sats per bitcoin.
-fn serde_as_btc_opt() {
+fn serde_amount_as_btc_opt() {
use serde_json;
#[derive(Serialize, Deserialize, PartialEq, Debug, Eq)]
@@ -213,7 +213,7 @@ fn serde_as_btc_opt() {
#[cfg(feature = "serde")]
#[cfg(feature = "alloc")]
#[allow(clippy::inconsistent_digit_grouping)] // Group to show 100,000,000 sats per bitcoin.
-fn serde_as_sat_opt() {
+fn serde_amount_as_sat_opt() {
use serde_json;
#[derive(Serialize, Deserialize, PartialEq, Debug, Eq)]
@@ -252,7 +252,7 @@ fn serde_as_sat_opt() {
#[cfg(feature = "serde")]
#[cfg(feature = "alloc")]
#[allow(clippy::inconsistent_digit_grouping)] // Group to show 100,000,000 sats per bitcoin.
-fn serde_as_str_opt() {
+fn serde_amount_as_str_opt() {
use serde_json;
#[derive(Serialize, Deserialize, PartialEq, Debug, Eq)]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.