primitives: Re-export all the public amount error types
What the developer wrote
Authored by Mitchell Bagot
primitives: Re-export all the public amount error types
With the introduction of 'error' modules throughout primitives, we can
re-export all of the public errors no_inline.
Re-export remaining errors (only FromHexError) in the super module of
their error module definitions.
What changed, and why it matters
This commit is a routine code organization change. It makes an existing error type (FromHexError) visible in more places by re-exporting it, so users of the library can import it more conveniently. There is no change to how errors are handled or any security-sensitive behavior.
No action required. This is a non-security API cleanup change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds FromHexError to the public re-exports in bitcoin/src/blockdata/script/mod.rs and primitives/src/script/mod.rs (the latter gated by the hex feature). This is purely an API visibility change using #[doc(no_inline)] re-exports. No logic, parsing, validation, or error-handling code is modified.
Changed components
bitcoin/src/blockdata/script/mod.rsprimitives/src/script/mod.rsInspect captured patch +5 / −1
diff --git a/bitcoin/src/blockdata/script/mod.rs b/bitcoin/src/blockdata/script/mod.rs
index c8a931d5..9fa8e3bb 100644
--- a/bitcoin/src/blockdata/script/mod.rs
+++ b/bitcoin/src/blockdata/script/mod.rs
@@ -88,7 +88,8 @@ pub use primitives::script::{
pub(crate) use self::borrowed::ScriptExtPriv;
#[doc(no_inline)]
pub use self::error::{
- Error, PushBytesError, RedeemScriptSizeError, ScriptIntError, WitnessScriptSizeError,
+ Error, FromHexError, PushBytesError, RedeemScriptSizeError, ScriptIntError,
+ WitnessScriptSizeError,
};
pub(crate) use self::owned::ScriptBufExtPriv;
diff --git a/primitives/src/script/mod.rs b/primitives/src/script/mod.rs
index d61e9cb3..301b7001 100644
--- a/primitives/src/script/mod.rs
+++ b/primitives/src/script/mod.rs
@@ -32,6 +32,9 @@ pub use self::{
tag::{Tag, RedeemScriptTag, ScriptPubKeyTag, ScriptSigTag, SignetBlockScriptTag, TapScriptTag, WitnessScriptTag},
};
#[doc(no_inline)]
+#[cfg(feature = "hex")]
+pub use self::error::FromHexError;
+#[doc(no_inline)]
pub use self::error::{RedeemScriptSizeError, ScriptBufDecoderError, WitnessScriptSizeError};
#[doc(inline)]
pub use crate::hash_types::{ScriptHash, WScriptHash};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.