What the developer wrote
Authored by Abeeujah
Drop use of deprecated methods
In sign-tx-segwit example, the deprecated `public_key` method was
still being used, not reflecting the now recommended `to_public_key`
method.
This patch drops the use of the deprecated method for the now recommended
method by the API.
What changed, and why it matters
This is a routine code cleanup in an example file. It replaces an old, deprecated method name (`public_key`) with the newer recommended name (`to_public_key`). There is no security issue here; the change only affects example documentation code and does not alter how the library works.
No security action needed. This is a non-functional cleanup change in example code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies bitcoin/examples/sign-tx-segwit-v0.rs, replacing two calls from sk.public_key() to sk.to_public_key(). The public_key method on PrivateKey was deprecated in favor of to_public_key. The functionality remains identical; only the API surface used in the example is updated to suppress deprecation warnings and reflect current best practice.
Changed components
bitcoin/examples/sign-tx-segwit-v0.rsInspect captured patch +2 / −2
diff --git a/bitcoin/examples/sign-tx-segwit-v0.rs b/bitcoin/examples/sign-tx-segwit-v0.rs
index 2f0a918a..36f24fd7 100644
--- a/bitcoin/examples/sign-tx-segwit-v0.rs
+++ b/bitcoin/examples/sign-tx-segwit-v0.rs
@@ -69,7 +69,7 @@ fn main() {
let signature = ecdsa::Signature { signature: sk.raw_ecdsa_sign(sighash), sighash_type };
// Update the witness stack.
- let pk = sk.public_key().force_compressed();
+ let pk = sk.to_public_key().force_compressed();
*sighasher.witness_mut(input_index).unwrap() = Witness::p2wpkh(signature, pk);
// Get the signed transaction.
@@ -84,7 +84,7 @@ fn main() {
/// In a real application these would be actual secrets.
fn senders_keys() -> (PrivateKey, WPubkeyHash) {
let sk = PrivateKey::generate();
- let pk = sk.public_key();
+ let pk = sk.to_public_key();
let wpkh = pk.wpubkey_hash().expect("key is compressed");
(sk, wpkh)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.