addresses,bip158,crypto: migrate lint settings
What the developer wrote
Authored by Nick Johnson
addresses,bip158,crypto: migrate lint settings
What changed, and why it matters
This commit is a routine housekeeping change that moves lint (code style warning) settings from individual crates to a shared workspace configuration. It does not change any program logic, fix bugs, or alter security behavior.
No security action needed. Treat as normal maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes per-crate Clippy lint declarations in addresses, bip158, and crypto crates, replacing them with workspace-level lint inheritance via [lints] workspace = true in each Cargo.toml. Some #![allow(...)] and #![warn(...)] attributes are removed from lib.rs files. No functional code is modified.
Changed components
addresses/Cargo.tomladdresses/src/lib.rsbip158/Cargo.tomlbip158/src/lib.rscrypto/Cargo.tomlcrypto/src/lib.rsInspect captured patch +6 / −23
diff --git a/addresses/Cargo.toml b/addresses/Cargo.toml
index bc9066de..92b137d3 100644
--- a/addresses/Cargo.toml
+++ b/addresses/Cargo.toml
@@ -25,6 +25,5 @@ alloc = []
all-features = true
rustdoc-args = ["--cfg", "docsrs"]
-[lints.clippy]
-redundant_clone = "warn"
-use_self = "warn"
+[lints]
+workspace = true
diff --git a/addresses/src/lib.rs b/addresses/src/lib.rs
index 74884fd4..6ea65e53 100644
--- a/addresses/src/lib.rs
+++ b/addresses/src/lib.rs
@@ -17,10 +17,6 @@
// Coding conventions.
#![warn(deprecated_in_future)]
#![warn(missing_docs)]
-// Exclude lints we don't think are valuable.
-#![allow(clippy::needless_question_mark)] // https://github.com/rust-bitcoin/rust-bitcoin/pull/2134
-#![allow(clippy::manual_range_contains)] // More readable than clippy's format.
-#![allow(clippy::uninlined_format_args)] // Allow `format!("{}", x)` instead of enforcing `format!("{x}")`
extern crate alloc;
diff --git a/bip158/Cargo.toml b/bip158/Cargo.toml
index b0ac9c2c..15a926e6 100644
--- a/bip158/Cargo.toml
+++ b/bip158/Cargo.toml
@@ -20,6 +20,5 @@ exclude = ["tests", "contrib"]
all-features = true
rustdoc-args = ["--cfg", "docsrs"]
-[lints.clippy]
-redundant_clone = "warn"
-use_self = "warn"
+[lints]
+workspace = true
diff --git a/bip158/src/lib.rs b/bip158/src/lib.rs
index 5ef86257..d4319af4 100644
--- a/bip158/src/lib.rs
+++ b/bip158/src/lib.rs
@@ -6,9 +6,3 @@
#![warn(missing_docs)]
#![warn(deprecated_in_future)]
#![doc(test(attr(warn(unused))))]
-// Pedantic lints that we enforce.
-#![warn(clippy::return_self_not_must_use)]
-// Exclude lints we don't think are valuable.
-#![allow(clippy::needless_question_mark)] // https://github.com/rust-bitcoin/rust-bitcoin/pull/2134
-#![allow(clippy::manual_range_contains)] // More readable than clippy's format.
-#![allow(clippy::uninlined_format_args)] // Allow `format!("{}", x)`instead of enforcing `format!("{x}")`
diff --git a/crypto/Cargo.toml b/crypto/Cargo.toml
index 548c9b99..5301946b 100644
--- a/crypto/Cargo.toml
+++ b/crypto/Cargo.toml
@@ -25,6 +25,5 @@ alloc = []
all-features = true
rustdoc-args = ["--cfg", "docsrs"]
-[lints.clippy]
-redundant_clone = "warn"
-use_self = "warn"
+[lints]
+workspace = true
diff --git a/crypto/src/lib.rs b/crypto/src/lib.rs
index 0d98f783..46f3f5e2 100644
--- a/crypto/src/lib.rs
+++ b/crypto/src/lib.rs
@@ -10,10 +10,6 @@
// Coding conventions.
#![warn(deprecated_in_future)]
#![warn(missing_docs)]
-// Exclude lints we don't think are valuable.
-#![allow(clippy::needless_question_mark)] // https://github.com/rust-bitcoin/rust-bitcoin/pull/2134
-#![allow(clippy::manual_range_contains)] // More readable than clippy's format.
-#![allow(clippy::uninlined_format_args)] // Allow `format!("{}", x)` instead of enforcing `format!("{x}")`
extern crate alloc;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.