Public commit record
68/100 · Adequate
What the developer wrote
Authored by Jamil Lambert, PhD
Add extra_lints.sh to all crates
rust-bitcoin-maintainer-tools has been updated and all the clippy
errors with no-default-features have been fixed.
Add extra_lints.sh to all crates with a command that runs clippy with
no-default-features. Running no-default-features on the workspace did
not give all of the clippy errors.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
What changed, and why it matters
This commit only adds new helper scripts that run an automated code-quality tool (Clippy) on each crate with default features disabled. It does not change any library code, fix a bug, or alter behavior. There is no security issue here.
Recommended action
No security action needed. Treat as a normal repository maintenance / CI tooling change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit creates identical extra_lints.sh shell scripts in 11 workspace crates. Each script runs cargo clippy --all-targets --no-default-features --keep-going -- -D warnings. This is a CI/developer tooling change to catch lint warnings in no-default-features configurations. No Rust source code is modified.
Changed components
addresses/contrib/extra_lints.shbase58/contrib/extra_lints.shbitcoin/contrib/extra_lints.shchacha20_poly1305/contrib/extra_lints.shconsensus_encoding/contrib/extra_lints.shhashes/contrib/extra_lints.shinternals/contrib/extra_lints.shio/contrib/extra_lints.shp2p/contrib/extra_lints.shprimitives/contrib/extra_lints.shunits/contrib/extra_lints.shInspect captured patch +55 / −0
diff --git a/addresses/contrib/extra_lints.sh b/addresses/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/addresses/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/base58/contrib/extra_lints.sh b/base58/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/base58/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/bitcoin/contrib/extra_lints.sh b/bitcoin/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/bitcoin/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/chacha20_poly1305/contrib/extra_lints.sh b/chacha20_poly1305/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/chacha20_poly1305/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/consensus_encoding/contrib/extra_lints.sh b/consensus_encoding/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/consensus_encoding/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/hashes/contrib/extra_lints.sh b/hashes/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/hashes/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/internals/contrib/extra_lints.sh b/internals/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/internals/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/io/contrib/extra_lints.sh b/io/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/io/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/p2p/contrib/extra_lints.sh b/p2p/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/p2p/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/primitives/contrib/extra_lints.sh b/primitives/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/primitives/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
diff --git a/units/contrib/extra_lints.sh b/units/contrib/extra_lints.sh
new file mode 100755
index 00000000..9c20f319
--- /dev/null
+++ b/units/contrib/extra_lints.sh
@@ -0,0 +1,5 @@
+#!/usr/bin/env bash
+
+set -ex
+
+cargo clippy --all-targets --no-default-features --keep-going -- -D warnings
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.