What the developer wrote
Authored by Mitchell Bagot
Fix lint errors
In the process of moving the tests in the previous commit, the stricter
lint requirements for the leaf crates has introduced some lint errors
that should be fixed.
What changed, and why it matters
This commit only fixes code style issues (lint errors). It adds underscores to large number literals and replaces a closure with a direct function reference in test code. There is no change to security-sensitive behavior.
No security action needed. Treat as a routine code-quality/lint cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates test code in primitives/src/block.rs and units/src/sequence.rs to satisfy stricter lint rules in leaf crates. Changes include numeric literal grouping (e.g., 0x20000000 -> 0x2000_0000, 2147483647 -> 2_147_483_647) and a closure-to-function-reference refactor (|obj| obj.compute_txid() -> Transaction::compute_txid). No logic, parsing, validation, or cryptographic code is altered.
Changed components
primitives/src/block.rs (tests only)units/src/sequence.rs (tests only)Inspect captured patch +9 / −9
diff --git a/primitives/src/block.rs b/primitives/src/block.rs
index 97aa5bf6..b02c028a 100644
--- a/primitives/src/block.rs
+++ b/primitives/src/block.rs
@@ -1063,7 +1063,7 @@ mod tests {
#[test]
fn soft_fork_signalling() {
for i in 0..31 {
- let version_int = (0x20000000u32 ^ (1 << i)) as i32;
+ let version_int = (0x2000_0000u32 ^ (1 << i)) as i32;
let version = Version::from_consensus(version_int);
if i < 29 {
assert!(version.is_signalling_soft_fork(i));
@@ -1072,7 +1072,7 @@ mod tests {
}
}
- let segwit_signal = Version::from_consensus(0x20000000 ^ (1 << 1));
+ let segwit_signal = Version::from_consensus(0x2000_0000 ^ (1 << 1));
assert!(!segwit_signal.is_signalling_soft_fork(0));
assert!(segwit_signal.is_signalling_soft_fork(1));
assert!(!segwit_signal.is_signalling_soft_fork(2));
@@ -2034,13 +2034,13 @@ mod tests {
assert!(decode.is_ok());
let real_decode = decode.unwrap().assume_checked(None);
- assert_eq!(real_decode.header().version, Version::from_consensus(2147483647));
+ assert_eq!(real_decode.header().version, Version::from_consensus(2_147_483_647));
let block2 = hex!("000000800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000");
let decode2: Result<Block<Unchecked>, _> = encoding::decode_from_slice(&block2);
assert!(decode2.is_ok());
let real_decode2 = decode2.unwrap().assume_checked(None);
- assert_eq!(real_decode2.header().version, Version::from_consensus(-2147483648));
+ assert_eq!(real_decode2.header().version, Version::from_consensus(-2_147_483_648));
}
#[test]
@@ -2056,7 +2056,7 @@ mod tests {
let block = Block::new_unchecked(header, transactions).assume_checked(None);
// Same as `block.check_merkle_root` but do it explicitly.
- let hashes_iter = block.transactions().iter().map(|obj| obj.compute_txid());
+ let hashes_iter = block.transactions().iter().map(Transaction::compute_txid);
let from_iter = TxMerkleNode::calculate_root(hashes_iter.clone());
assert_eq!(from_iter, Some(block.header().merkle_root));
}
diff --git a/units/src/sequence.rs b/units/src/sequence.rs
index 6ba7c543..c33e3e93 100644
--- a/units/src/sequence.rs
+++ b/units/src/sequence.rs
@@ -421,11 +421,11 @@ mod tests {
#[test]
fn sequence_number() {
- let seq_final = Sequence::from_consensus(0xFFFFFFFF);
- let seq_non_rbf = Sequence::from_consensus(0xFFFFFFFE);
+ let seq_final = Sequence::from_consensus(0xFFFF_FFFF);
+ let seq_non_rbf = Sequence::from_consensus(0xFFFF_FFFE);
let block_time_lock = Sequence::from_consensus(0xFFFF);
- let unit_time_lock = Sequence::from_consensus(0x40FFFF);
- let lock_time_disabled = Sequence::from_consensus(0x80000000);
+ let unit_time_lock = Sequence::from_consensus(0x40_FFFF);
+ let lock_time_disabled = Sequence::from_consensus(0x8000_0000);
assert!(seq_final.is_final());
assert!(!seq_final.is_rbf());
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.