Replace wildcard import with a single import
What the developer wrote
Authored by Martin Habovstiak
Replace wildcard import with a single import
Clippy started complaining about the use of `super::*` in the
`taproot::into_iter` module, which seems to make sense since that import
actually only imported a single item and was confusing.
This commit just imports the single item, since there shouldn't be need
for the wildcard.
What changed, and why it matters
This is a trivial code cleanup: a developer replaced a wildcard import (`use super::*`) with a single explicit import (`use super::SerializedSignature`) in a small internal module. It has no security relevance; it only makes the code clearer and silences a Clippy lint.
No action needed. This is a non-security refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In crypto/src/taproot.rs, the into_iter submodule previously imported everything from its parent via use super::*. The commit changes this to use super::SerializedSignature, which is the only item actually used. This is a refactor to satisfy Clippy and improve readability; no logic, API, or behavior changed.
Changed components
crypto/src/taproot.rsInspect captured patch +1 / −1
diff --git a/crypto/src/taproot.rs b/crypto/src/taproot.rs
index 02558183..d02474d3 100644
--- a/crypto/src/taproot.rs
+++ b/crypto/src/taproot.rs
@@ -314,7 +314,7 @@ impl<'a> TryFrom<&'a SerializedSignature> for Signature {
/// Separate mod to prevent outside code from accidentally breaking invariants.
mod into_iter {
- use super::*;
+ use super::SerializedSignature;
/// Owned iterator over the bytes of [`SerializedSignature`]
///
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.