What the developer wrote
Authored by Jamil Lambert, PhD
Update mutant excludes
There are new mutants for cases that have previously been excluded due
to a difference in the path of the exclusion. There is also a timeout
where changing an = to != in push_bytes makes the decoding never end.
Make the exclusions more general to cover these cases.
Add an exclusion for the timeout.
What changed, and why it matters
This commit only updates a configuration file used for mutation testing. It tells the mutation-testing tool to skip certain patterns that would otherwise cause test runs to hang. There is no change to the actual Bitcoin library code, no bug fix, and no security patch.
No security action needed. This is a testing-tool configuration change only.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .cargo/mutants.toml, which configures cargo-mutants. It broadens some existing regex exclusions and adds one new exclusion for
Changed components
.cargo/mutants.tomlInspect captured patch +5 / −4
diff --git a/.cargo/mutants.toml b/.cargo/mutants.toml
index bd721b4b..c9851566 100644
--- a/.cargo/mutants.toml
+++ b/.cargo/mutants.toml
@@ -11,8 +11,8 @@ exclude_re = [
"deserialize", # Skip serde mutation tests
"serde_details::<impl de::Visitor<'_>", # Skip serde mutation tests
"Iterator", # Mutating operations in an iterator can result in an infinite loop
- "<impl encoding::Decodable for .*>::decoder", # Mutant replacing Default::default() is equivalent to returning new()
- "<impl encoding::Decoder for .*>::read_limit", # Function is for optimization and does not need to be tested.
+ "<impl .*Decodable for .*>::decoder", # Mutant replacing Default::default() is equivalent to returning new()
+ "<impl .*Decoder for .*>::read_limit", # Function is for optimization and does not need to be tested.
# ----------------------------------Crate-specific exclusions----------------------------------
@@ -46,6 +46,7 @@ exclude_re = [
"Script<T>::to_hex", # Deprecated
"ScriptBuf::to_hex", # Deprecated
"ScriptBuf<T>::to_hex", # Deprecated
- "<impl Encoder for WitnessEncoder<'_>>::current_chunk", # Replacing the return with Some(vec![]) causes an infinite loop.
- "<impl Encoder for WitnessEncoder<'_>>::advance", # Replacing the return with true causes an infinite loop.
+ "<impl Encoder for .*Encoder<'_>>::current_chunk", # Replacing the return with Some(vec![]) causes an infinite loop.
+ "<impl Encoder for .*Encoder<'_>>::advance", # Replacing the return with true causes an infinite loop.
+ "<impl Decoder for WitnessDecoder>::push_bytes", # Replacing == with != causes an infinite loop
]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.