What the developer wrote
Authored by Tobin C. Harding
bitcoin: Do not inline block errors
Convention is to use `no_inline` when re-exporting error types. Fix
the re-exports from the `bitcoin::block` module.
What changed, and why it matters
This is a cosmetic documentation-only change. It moves two error types from an inline re-export list to a separate non-inline re-export list, matching the project's existing style convention. There is no functional code change and no security impact.
No action required. This is a non-security documentation/style change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes #[doc(inline)] to #[doc(no_inline)] for InvalidBlockError and ParseHeaderError in bitcoin/src/blockdata/block.rs. This affects only how Rustdoc displays the re-exported types; it does not change visibility, type definitions, behavior, or generated code. The diff shows a pure reorganization of pub use statements.
Changed components
bitcoin/src/blockdata/block.rsInspect captured patch +3 / −1
diff --git a/bitcoin/src/blockdata/block.rs b/bitcoin/src/blockdata/block.rs
index ab938f97..bc37dbf6 100644
--- a/bitcoin/src/blockdata/block.rs
+++ b/bitcoin/src/blockdata/block.rs
@@ -26,9 +26,11 @@ use crate::{internal_macros, BlockTime, Target, Weight, Work};
#[doc(inline)]
pub use primitives::block::{
Block, Checked, Unchecked, Validation, Version, BlockHash, Header,
- WitnessCommitment, compute_merkle_root, compute_witness_root, InvalidBlockError, ParseHeaderError,
+ WitnessCommitment, compute_merkle_root, compute_witness_root,
};
#[doc(no_inline)]
+pub use primitives::block::{InvalidBlockError, ParseHeaderError};
+#[doc(no_inline)]
pub use units::block::TooBigForRelativeHeightError;
#[doc(inline)]
pub use units::block::{BlockHeight, BlockHeightInterval, BlockMtp, BlockMtpInterval};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.