What the developer wrote
Authored by Tobin C. Harding
Iterate on just the map values
Found by clippy and the new nightly toolchain update in (#5743).
No logic change.
What changed, and why it matters
This is a trivial code cleanup: a test was iterating over key-value pairs of a map and ignoring the key, and it was changed to iterate over just the values. The commit explicitly says 'No logic change' and the diff confirms it. There is no security issue.
No action needed. This is a benign refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In bitcoin/src/bip158.rs, a test calls filter.match_all() with an iterator over txmap. The original code used txmap.iter().filter_map(|(_, s)| …) to discard the key and keep the value. The patch changes this to txmap.values().filter_map(|s| …), which is semantically identical and was flagged by a Clippy lint on newer Rust nightly. This is a refactor with no behavioral change.
Changed components
bitcoin/src/bip158.rs test code onlyInspect captured patch +1 / −1
diff --git a/bitcoin/src/bip158.rs b/bitcoin/src/bip158.rs
index 92c7789f..1bef8a59 100644
--- a/bitcoin/src/bip158.rs
+++ b/bitcoin/src/bip158.rs
@@ -591,7 +591,7 @@ mod test {
assert!(filter
.match_all(
*block_hash,
- &mut txmap.iter().filter_map(|(_, s)| if !s.is_empty() {
+ &mut txmap.values().filter_map(|s| if !s.is_empty() {
Some(s.as_bytes())
} else {
None
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.