What the developer wrote
Authored by Martin Habovstiak
Simplyfy `impl Display for Magic`
The implementation was exactly the same as for `LowerHex`, which is
slightly less clear than just calling into `LowerHex` and makes the
compiler work a bit more.
This commit changes it to simply call into `LowerHex`.
What changed, and why it matters
This is a tiny internal code cleanup. It changes how a network 'magic' number is printed on screen so that one formatting routine reuses another identical routine, instead of duplicating the same logic. There is no security relevance.
No action required. Treat as a normal non-security refactoring commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors impl fmt::Display for Magic in p2p/src/lib.rs to delegate to the existing LowerHex implementation rather than calling hex_unstable::fmt_hex_exact! directly. The behavior is unchanged; it is purely a readability and minor compile-efficiency improvement.
Changed components
p2p/src/lib.rsMagic Display formattingInspect captured patch +1 / −2
diff --git a/p2p/src/lib.rs b/p2p/src/lib.rs
index c2c75302..61153e93 100644
--- a/p2p/src/lib.rs
+++ b/p2p/src/lib.rs
@@ -423,8 +423,7 @@ impl TryFrom<Magic> for Network {
impl fmt::Display for Magic {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- hex_unstable::fmt_hex_exact!(f, 4, &self.0, hex_unstable::Case::Lower)?;
- Ok(())
+ fmt::LowerHex::fmt(self, f)
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.