Remove clippy config entry: match_on_vec_items
What the developer wrote
Authored by Tobin C. Harding
Remove clippy config entry: match_on_vec_items
Clippy emits:
warning: lint `clippy::match_on_vec_items` has been removed:
`clippy::indexing_slicing` covers indexing and slicing on `Vec<_>`
IIUC one can add any just as a lint config and it just triggers a
warning and does nothing else so this usage of a removed lint config
item is essentially a no-op. Removing it makes no difference other
than removing the warning.
FTR `indexing_slicing` is not a drop in replacement because it is more
restrictive, we can use it in `units` with no other changes but not in
`primitives`.
What changed, and why it matters
This commit only changes Clippy lint configuration in two Cargo.toml files. It removes a no-longer-existing lint setting and, in one crate, swaps it for a stricter but unrelated lint. There is no change to actual Bitcoin logic, no bug fix, and no security relevance.
No action required. This is a routine cleanup of static-analysis configuration.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes match_on_vec_items = "warn" from primitives/Cargo.toml and replaces it with indexing_slicing = "warn" in units/Cargo.toml. The commit message explicitly states the removed lint is a no-op because Clippy ignores it with a warning. The replacement lint is more restrictive and only affects static analysis warnings for indexing/slicing patterns. No source code, APIs, or runtime behavior are modified.
Changed components
primitives/Cargo.tomlunits/Cargo.tomlInspect captured patch +1 / −2
diff --git a/primitives/Cargo.toml b/primitives/Cargo.toml
index 7af43f83..cf553c47 100644
--- a/primitives/Cargo.toml
+++ b/primitives/Cargo.toml
@@ -103,7 +103,6 @@ manual_string_new = "warn"
many_single_char_names = "warn"
map_unwrap_or = "warn"
match_bool = "allow" # Adds extra indentation and LOC.
-match_on_vec_items = "warn"
match_same_arms = "allow" # Collapses things that are conceptually unrelated to each other.
match_wild_err_arm = "warn"
match_wildcard_for_single_variants = "warn"
diff --git a/units/Cargo.toml b/units/Cargo.toml
index 64291d24..fc329fee 100644
--- a/units/Cargo.toml
+++ b/units/Cargo.toml
@@ -100,7 +100,7 @@ manual_string_new = "warn"
many_single_char_names = "warn"
map_unwrap_or = "warn"
match_bool = "allow" # Adds extra indentation and LOC.
-match_on_vec_items = "warn"
+indexing_slicing = "warn"
match_same_arms = "allow" # Collapses things that are conceptually unrelated to each other.
match_wild_err_arm = "warn"
match_wildcard_for_single_variants = "warn"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.