What the developer wrote
Authored by Mitchell Bagot
Make ToU64 private
The ToU64 trait was moved from internals to bitcoin recently. When
moved, it was made public in bitcoin as it was used in the public API
of some of the old consensus code. With that consensus code removed,
the trait should be made private.
Make ToU64 pub(crate).
What changed, and why it matters
This commit simply changes a Rust helper trait from public to private visibility (pub(crate)). It is a routine API-cleanup change with no security relevance. The trait converts integer sizes to u64 and is no longer needed in any public interface.
No security action required. Treat as normal API-hardening / cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The ToU64 trait in bitcoin/src/lib.rs is changed from pub trait ToU64 to pub(crate) trait ToU64. The commit message explains the trait was accidentally left public after a refactor and, with the dependent public consensus code removed, it can now be restricted to crate-internal visibility. This is a non-functional visibility change.
Changed components
bitcoin/src/lib.rsInspect captured patch +1 / −1
diff --git a/bitcoin/src/lib.rs b/bitcoin/src/lib.rs
index e42a8648..75d199ae 100644
--- a/bitcoin/src/lib.rs
+++ b/bitcoin/src/lib.rs
@@ -266,7 +266,7 @@ pub mod amount {
///
/// This trait exists because [`usize`] doesn't implement `Into<u64>`. We only support 32 and 64 bit
/// architectures because of consensus code so we can infallibly do the conversion.
-pub trait ToU64 {
+pub(crate) trait ToU64 {
/// Converts unsigned integer type to a [`u64`].
fn to_u64(self) -> u64;
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.