Public commit record
61/100 · Adequate
What the developer wrote
Authored by Martin Habovstiak
Delete redundant tests
Compact size encoding is properly tested in its module and the tests in
`tests/encode.rs` were testing the same things, so this commit deletes
them.
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification
What changed, and why it matters
This commit simply removes duplicate unit tests from a Rust Bitcoin encoding library. The deleted tests covered the same compact-size encoding behavior that is already tested elsewhere, so no code logic changed and there is no security impact.
Recommended action
No action required; this is a routine test-cleanup commit with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes two test functions, encode_compact_size_boundary_values and encode_compact_size, from consensus_encoding/tests/encode.rs and removes the now-unused CompactSizeEncoder import. The commit message states these tests were redundant because compact-size encoding is already tested in its own module. No production code was modified.
Changed components
consensus_encoding/tests/encode.rsInspect captured patch +1 / −81
diff --git a/consensus_encoding/tests/encode.rs b/consensus_encoding/tests/encode.rs
index 8d2d44ac..e95a7611 100644
--- a/consensus_encoding/tests/encode.rs
+++ b/consensus_encoding/tests/encode.rs
@@ -6,7 +6,7 @@
use std::io::{Cursor, Write};
use bitcoin_consensus_encoding::{
- ArrayEncoder, ArrayRefEncoder, BytesEncoder, CompactSizeEncoder, Encode, Encoder, Encoder2,
+ ArrayEncoder, ArrayRefEncoder, BytesEncoder, Encode, Encoder, Encoder2,
Encoder3, Encoder4, Encoder6, EncoderByteIter, ExactSizeEncoder, SliceEncoder,
};
@@ -176,26 +176,6 @@ fn encode_slice_encoder_mixed_empty_and_data() {
assert!(!encoder.advance());
}
-#[test]
-fn encode_compact_size_boundary_values() {
- // Test CompactSizeEncoder with boundary values.
- let mut encoder = CompactSizeEncoder::new(252usize);
- assert_eq!(encoder.current_chunk(), &[252]);
- assert!(!encoder.advance());
-
- let mut encoder = CompactSizeEncoder::new(253usize);
- assert_eq!(encoder.current_chunk(), &[0xFD, 253, 0]);
- assert!(!encoder.advance());
-
- let mut encoder = CompactSizeEncoder::new(0x10000usize);
- assert_eq!(encoder.current_chunk(), &[0xFE, 0, 0, 1, 0]);
- assert!(!encoder.advance());
-
- let mut encoder = CompactSizeEncoder::new(0usize);
- assert_eq!(encoder.current_chunk(), &[0]);
- assert!(!encoder.advance());
-}
-
#[test]
fn encode_encoder2_with_first_empty_encoder() {
// Test Encoder2 when first encoder produces no data.
@@ -554,66 +534,6 @@ fn encode_complex_nested_structure() {
assert!(!encoder.advance());
}
-#[test]
-fn encode_compact_size() {
- // 1-byte
- let mut e = CompactSizeEncoder::new(0x10usize);
- assert_eq!(e.current_chunk(), &[0x10][..]);
- assert_eq!(e.len(), 1);
- assert!(!e.advance());
-
- let mut e = CompactSizeEncoder::new(0xFCusize);
- assert_eq!(e.current_chunk(), &[0xFC][..]);
- assert_eq!(e.len(), 1);
- assert!(!e.advance());
-
- // 0xFD + u16
- let mut e = CompactSizeEncoder::new(0x00FDusize);
- assert_eq!(e.current_chunk(), &[0xFD, 0xFD, 0x00][..]);
- assert_eq!(e.len(), 3);
- assert!(!e.advance());
-
- let mut e = CompactSizeEncoder::new(0x0FFFusize);
- assert_eq!(e.current_chunk(), &[0xFD, 0xFF, 0x0F][..]);
- assert_eq!(e.len(), 3);
- assert!(!e.advance());
-
- // 0xFE + u32
- let mut e = CompactSizeEncoder::new(0x0001_0000usize);
- assert_eq!(e.current_chunk(), &[0xFE, 0x00, 0x00, 0x01, 0x00][..]);
- assert_eq!(e.len(), 5);
- assert!(!e.advance());
-
- let mut e = CompactSizeEncoder::new(0x0F0F_0F0Fusize);
- assert_eq!(e.current_chunk(), &[0xFE, 0x0F, 0x0F, 0x0F, 0x0F][..]);
- assert_eq!(e.len(), 5);
- assert!(!e.advance());
-
- // 0xFF + u64
- // This test only runs on systems with >= 64 bit usize.
- if core::mem::size_of::<usize>() >= 8 {
- let mut e = CompactSizeEncoder::new(0x0000_F0F0_F0F0_F0E0u64 as usize);
- assert_eq!(e.current_chunk(), &[0xFF, 0xE0, 0xF0, 0xF0, 0xF0, 0xF0, 0xF0, 0x00, 0x00][..]);
- assert_eq!(e.len(), 9);
- assert!(!e.advance());
- }
-
- // > u64::MAX encodes as u64::MAX.
- // This test only runs on systems with > 64 bit usize.
- if core::mem::size_of::<usize>() > 8 {
- let mut e = CompactSizeEncoder::new((u128::from(u64::MAX) + 5) as usize);
- assert_eq!(e.current_chunk(), &[0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF][..]);
- assert_eq!(e.len(), 9);
- assert!(!e.advance());
- }
-
- // new_u64 works on all platforms, no guard needed.
- let mut e = CompactSizeEncoder::new_u64(0x0000_F0F0_F0F0_F0E0u64);
- assert_eq!(e.current_chunk(), &[0xFF, 0xE0, 0xF0, 0xF0, 0xF0, 0xF0, 0xF0, 0x00, 0x00][..]);
- assert_eq!(e.len(), 9);
- assert!(!e.advance());
-}
-
#[test]
fn iter_encoder() {
let test_array = TestArray([1u8, 2, 3, 4]);
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.