What the developer wrote
Authored by Shing Him Ng
Remove unnecessary check
What changed, and why it matters
This commit removes a redundant error-message assertion from three internal fuzz-testing programs. The removed line only printed a nicer message when a deserialization failed; the very next line still checks that the round-trip result matches the original value. It does not change any production library code, user-facing APIs, or security behavior.
No action required; this is a code-cleanup change in test-only fuzz targets.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In fuzz/fuzz_targets/bitcoin/{arbitrary_block.rs, arbitrary_transaction.rs, arbitrary_witness.rs}, the commit deletes an assert!(deserialized.is_ok(), …) statement that was immediately followed by assert_eq!(deserialized.unwrap(), original). The unwrap() on the next line will still panic if deserialization fails, so the only functional change is the loss of a custom panic message in the fuzz harness. No library code is modified.
Changed components
fuzz/fuzz_targets/bitcoin/arbitrary_block.rsfuzz/fuzz_targets/bitcoin/arbitrary_transaction.rsfuzz/fuzz_targets/bitcoin/arbitrary_witness.rsInspect captured patch +0 / −3
diff --git a/fuzz/fuzz_targets/bitcoin/arbitrary_block.rs b/fuzz/fuzz_targets/bitcoin/arbitrary_block.rs
index a96c160c..79bd2ada 100644
--- a/fuzz/fuzz_targets/bitcoin/arbitrary_block.rs
+++ b/fuzz/fuzz_targets/bitcoin/arbitrary_block.rs
@@ -23,7 +23,6 @@ fn do_test(data: &[u8]) {
}
let deserialized: Result<Block, _> = deserialize(serialized.as_slice());
- assert!(deserialized.is_ok(), "Deserialization error: {:?}", deserialized.err().unwrap());
assert_eq!(deserialized.unwrap(), block);
}
}
diff --git a/fuzz/fuzz_targets/bitcoin/arbitrary_transaction.rs b/fuzz/fuzz_targets/bitcoin/arbitrary_transaction.rs
index b30cca45..be1005df 100644
--- a/fuzz/fuzz_targets/bitcoin/arbitrary_transaction.rs
+++ b/fuzz/fuzz_targets/bitcoin/arbitrary_transaction.rs
@@ -11,7 +11,6 @@ fn do_test(data: &[u8]) {
if let Ok(mut tx) = t {
let serialized = serialize(&tx);
let deserialized: Result<Transaction, _> = deserialize(serialized.as_slice());
- assert!(deserialized.is_ok(), "Deserialization error: {:?}", deserialized.err().unwrap());
assert_eq!(deserialized.unwrap(), tx);
let len = serialized.len();
diff --git a/fuzz/fuzz_targets/bitcoin/arbitrary_witness.rs b/fuzz/fuzz_targets/bitcoin/arbitrary_witness.rs
index c61ba466..2681102d 100644
--- a/fuzz/fuzz_targets/bitcoin/arbitrary_witness.rs
+++ b/fuzz/fuzz_targets/bitcoin/arbitrary_witness.rs
@@ -14,7 +14,6 @@ fn do_test(data: &[u8]) {
let _ = witness.taproot_leaf_script();
let deserialized: Result<Witness, _> = deserialize(serialized.as_slice());
- assert!(deserialized.is_ok(), "Deserialization error: {:?}", deserialized.err().unwrap());
assert_eq!(deserialized.unwrap(), witness);
if let Ok(element_bytes) = Vec::<u8>::arbitrary(&mut u) {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.