ci: add bitcoin_hashes and bitcoin-network-kind to SEMVER_HARD_FAIL_CRATES
What the developer wrote
Authored by jrakibi
ci: add bitcoin_hashes and bitcoin-network-kind to SEMVER_HARD_FAIL_CRATES
Currently only bitcoin-consensus-encoding is listed as a hard-fail crate.
bitcoin_hashes and bitcoin-network-kind are 1.0 too, so add them to
SEMVER_HARD_FAIL_CRATES.
What changed, and why it matters
This commit only changes a CI script that lists which Rust crates must follow strict semantic-versioning rules. It adds two already-released 1.0 crates to the hard-fail list so future pull requests will fail automated checks if they accidentally break backward compatibility. There is no change to library code, no bug fix, and no security relevance.
No security action needed. Treat as a normal CI/process improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates contrib/check-semver-pr.sh, expanding SEMVER_HARD_FAIL_CRATES from [“bitcoin-consensus-encoding”] to [“bitcoin-consensus-encoding”, “bitcoin_hashes”, “bitcoin-network-kind”]. This is a build/quality-guard configuration change; it does not modify any source code, API, or runtime behavior of the rust-bitcoin libraries.
Changed components
contrib/check-semver-pr.shInspect captured patch +1 / −1
diff --git a/contrib/check-semver-pr.sh b/contrib/check-semver-pr.sh
index 9bca1d1d..b4107549 100755
--- a/contrib/check-semver-pr.sh
+++ b/contrib/check-semver-pr.sh
@@ -17,7 +17,7 @@ set -euo pipefail
RUSTDOCFLAGS="-Z unstable-options --document-private-items --document-hidden-items --output-format=json --cap-lints=allow"
# Crates that have reached 1.0 must not introduce semver-breaking API changes.
-SEMVER_HARD_FAIL_CRATES=("bitcoin-consensus-encoding")
+SEMVER_HARD_FAIL_CRATES=("bitcoin-consensus-encoding" "bitcoin_hashes" "bitcoin-network-kind")
# These will be set to the commit SHA from the PR's target branch
# GitHub Actions CI.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.